Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: src/objects-debug.cc

Issue 2900703002: [es2015] Precompute the descriptive string for symbols. (Closed)
Patch Set: Address feedback. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/objects.h" 5 #include "src/objects.h"
6 6
7 #include "src/assembler-inl.h" 7 #include "src/assembler-inl.h"
8 #include "src/bootstrapper.h" 8 #include "src/bootstrapper.h"
9 #include "src/disasm.h" 9 #include "src/disasm.h"
10 #include "src/disassembler.h" 10 #include "src/disassembler.h"
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 HeapObject* ho = HeapObject::cast(p); 268 HeapObject* ho = HeapObject::cast(p);
269 CHECK(ho->GetHeap()->Contains(ho)); 269 CHECK(ho->GetHeap()->Contains(ho));
270 } 270 }
271 271
272 272
273 void Symbol::SymbolVerify() { 273 void Symbol::SymbolVerify() {
274 CHECK(IsSymbol()); 274 CHECK(IsSymbol());
275 CHECK(HasHashCode()); 275 CHECK(HasHashCode());
276 CHECK(Hash() > 0u); 276 CHECK(Hash() > 0u);
277 CHECK(name()->IsUndefined(GetIsolate()) || name()->IsString()); 277 CHECK(name()->IsUndefined(GetIsolate()) || name()->IsString());
278 CHECK(descriptive_string()->IsString());
278 } 279 }
279 280
280 281
281 void HeapNumber::HeapNumberVerify() { 282 void HeapNumber::HeapNumberVerify() {
282 CHECK(IsHeapNumber() || IsMutableHeapNumber()); 283 CHECK(IsHeapNumber() || IsMutableHeapNumber());
283 } 284 }
284 285
285 void ByteArray::ByteArrayVerify() { 286 void ByteArray::ByteArrayVerify() {
286 CHECK(IsByteArray()); 287 CHECK(IsByteArray());
287 } 288 }
(...skipping 1360 matching lines...) Expand 10 before | Expand all | Expand 10 after
1648 1649
1649 // Both are done at the same time. 1650 // Both are done at the same time.
1650 CHECK_EQ(new_it.done(), old_it.done()); 1651 CHECK_EQ(new_it.done(), old_it.done());
1651 } 1652 }
1652 1653
1653 1654
1654 #endif // DEBUG 1655 #endif // DEBUG
1655 1656
1656 } // namespace internal 1657 } // namespace internal
1657 } // namespace v8 1658 } // namespace v8
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698