Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: src/builtins/arm64/builtins-arm64.cc

Issue 2900703002: [es2015] Precompute the descriptive string for symbols. (Closed)
Patch Set: Address feedback. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/arm/builtins-arm.cc ('k') | src/builtins/builtins-symbol.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/arm64/frames-arm64.h" 7 #include "src/arm64/frames-arm64.h"
8 #include "src/arm64/macro-assembler-arm64-inl.h" 8 #include "src/arm64/macro-assembler-arm64-inl.h"
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/counters.h" 10 #include "src/counters.h"
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 __ SmiTag(x2); 291 __ SmiTag(x2);
292 __ EnterBuiltinFrame(cp, x1, x2); 292 __ EnterBuiltinFrame(cp, x1, x2);
293 __ Call(masm->isolate()->builtins()->ToString(), RelocInfo::CODE_TARGET); 293 __ Call(masm->isolate()->builtins()->ToString(), RelocInfo::CODE_TARGET);
294 __ LeaveBuiltinFrame(cp, x1, x2); 294 __ LeaveBuiltinFrame(cp, x1, x2);
295 __ SmiUntag(x2); 295 __ SmiUntag(x2);
296 } 296 }
297 __ b(&drop_frame_and_ret); 297 __ b(&drop_frame_and_ret);
298 298
299 // 3b. Convert symbol in x0 to a string. 299 // 3b. Convert symbol in x0 to a string.
300 __ Bind(&symbol_descriptive_string); 300 __ Bind(&symbol_descriptive_string);
301 { 301 __ Ldr(x0, FieldMemOperand(x0, Symbol::kDescriptiveStringOffset));
302 __ Drop(x2); 302 // Fall through.
303 __ Drop(1);
304 __ Push(x0);
305 __ TailCallRuntime(Runtime::kSymbolDescriptiveString);
306 }
307 303
308 __ bind(&drop_frame_and_ret); 304 __ bind(&drop_frame_and_ret);
309 { 305 {
310 __ Drop(x2); 306 __ Drop(x2);
311 __ Drop(1); 307 __ Drop(1);
312 __ Ret(); 308 __ Ret();
313 } 309 }
314 } 310 }
315 311
316 // static 312 // static
(...skipping 2897 matching lines...) Expand 10 before | Expand all | Expand 10 after
3214 // Now jump to the instructions of the returned code object. 3210 // Now jump to the instructions of the returned code object.
3215 __ Jump(x8); 3211 __ Jump(x8);
3216 } 3212 }
3217 3213
3218 #undef __ 3214 #undef __
3219 3215
3220 } // namespace internal 3216 } // namespace internal
3221 } // namespace v8 3217 } // namespace v8
3222 3218
3223 #endif // V8_TARGET_ARCH_ARM 3219 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/builtins/arm/builtins-arm.cc ('k') | src/builtins/builtins-symbol.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698