Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
index 25c5cf77083157453ed137238b9d893679946a6f..a73c046aafaf332e2b340de951e01a7144994362 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
@@ -69,7 +69,7 @@ ManagePasswordsUIController::ManagePasswordsUIController(
ManagePasswordsUIController::~ManagePasswordsUIController() {}
void ManagePasswordsUIController::OnPasswordSubmitted(
- std::unique_ptr<PasswordFormManager> form_manager) {
+ scoped_refptr<PasswordFormManager> form_manager) {
bool show_bubble = !form_manager->IsBlacklisted();
DestroyAccountChooser();
passwords_data_.OnPendingPassword(std::move(form_manager));
@@ -87,7 +87,7 @@ void ManagePasswordsUIController::OnPasswordSubmitted(
}
void ManagePasswordsUIController::OnUpdatePasswordSubmitted(
- std::unique_ptr<PasswordFormManager> form_manager) {
+ scoped_refptr<PasswordFormManager> form_manager) {
DestroyAccountChooser();
passwords_data_.OnUpdatePassword(std::move(form_manager));
bubble_status_ = SHOULD_POP_UP;
@@ -142,7 +142,7 @@ void ManagePasswordsUIController::OnPromptEnableAutoSignin() {
}
void ManagePasswordsUIController::OnAutomaticPasswordSave(
- std::unique_ptr<PasswordFormManager> form_manager) {
+ scoped_refptr<PasswordFormManager> form_manager) {
DestroyAccountChooser();
passwords_data_.OnAutomaticPasswordSave(std::move(form_manager));
bubble_status_ = SHOULD_POP_UP;

Powered by Google App Engine
This is Rietveld 408576698