chrome/browser/password_manager/save_password_infobar_delegate_android.cc - Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate_android.cc

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/save_password_infobar_delegate_android.h ('k') | chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/save_password_infobar_delegate_android.cc

diff --git a/chrome/browser/password_manager/save_password_infobar_delegate_android.cc b/chrome/browser/password_manager/save_password_infobar_delegate_android.cc

index 25958094e82ee0e715dbc99b7909c0a05df0ba5b..5282d242d3e2b88ab4fa12d00b34007bfecb1381 100644

--- a/chrome/browser/password_manager/save_password_infobar_delegate_android.cc

+++ b/chrome/browser/password_manager/save_password_infobar_delegate_android.cc

@@ -26,7 +26,7 @@

// static

void SavePasswordInfoBarDelegate::Create(

content::WebContents* web_contents,

- std::unique_ptr<password_manager::PasswordFormManager> form_to_save) {

+ scoped_refptr<password_manager::PasswordFormManager> form_to_save) {

Profile* profile =

Profile::FromBrowserContext(web_contents->GetBrowserContext());

syncer::SyncService* sync_service =

@@ -47,7 +47,7 @@ SavePasswordInfoBarDelegate::~SavePasswordInfoBarDelegate() {

SavePasswordInfoBarDelegate::SavePasswordInfoBarDelegate(

content::WebContents* web_contents,

- std::unique_ptr<password_manager::PasswordFormManager> form_to_save,

+ scoped_refptr<password_manager::PasswordFormManager> form_to_save,

bool is_smartlock_branding_enabled)

: PasswordManagerInfoBarDelegate(),

form_to_save_(std::move(form_to_save)),