Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2143)

Unified Diff: chrome/browser/password_manager/password_manager_test_base.cc

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_test_base.cc
diff --git a/chrome/browser/password_manager/password_manager_test_base.cc b/chrome/browser/password_manager/password_manager_test_base.cc
index 5a5fa13b05aef0ff361691e09bc91027a60704bf..b1f3c17ff85ab2b12192c4610687029a1bb51fb0 100644
--- a/chrome/browser/password_manager/password_manager_test_base.cc
+++ b/chrome/browser/password_manager/password_manager_test_base.cc
@@ -65,9 +65,8 @@ class CustomManagePasswordsUIController : public ManagePasswordsUIController {
private:
// PasswordsClientUIDelegate:
- void OnPasswordSubmitted(
- std::unique_ptr<password_manager::PasswordFormManager> form_manager)
- override;
+ void OnPasswordSubmitted(scoped_refptr<password_manager::PasswordFormManager>
+ form_manager) override;
bool OnChooseCredentials(
std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,
const GURL& origin,
@@ -110,7 +109,7 @@ void CustomManagePasswordsUIController::WaitForState(
}
void CustomManagePasswordsUIController::OnPasswordSubmitted(
- std::unique_ptr<password_manager::PasswordFormManager> form_manager) {
+ scoped_refptr<password_manager::PasswordFormManager> form_manager) {
if (target_state_ == password_manager::ui::PENDING_PASSWORD_STATE) {
run_loop_->Quit();
run_loop_ = nullptr;

Powered by Google App Engine
This is Rietveld 408576698