ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h - Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_manager_unittest.cc ('K') | « ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm ('k') | ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h

diff --git a/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h b/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h

index afc444a499807753e2c4be23f193ce35b937f0bf..a36385fd7f8305db7b07529e172f9694431b0087 100644

--- a/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h

+++ b/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.h

@@ -26,7 +26,7 @@ class IOSChromePasswordManagerInfoBarDelegate : public ConfirmInfoBarDelegate {

protected:

IOSChromePasswordManagerInfoBarDelegate(

bool is_smart_lock_branding_enabled,

- std::unique_ptr<password_manager::PasswordFormManager> form_manager);

+ scoped_refptr<password_manager::PasswordFormManager> form_manager);

password_manager::PasswordFormManager* form_to_save() const {

return form_to_save_.get();

@@ -50,7 +50,7 @@ class IOSChromePasswordManagerInfoBarDelegate : public ConfirmInfoBarDelegate {

// The password_manager::PasswordFormManager managing the form we're asking

// the user about, and should save as per their decision.

- std::unique_ptr<password_manager::PasswordFormManager> form_to_save_;

+ scoped_refptr<password_manager::PasswordFormManager> form_to_save_;

// Used to track the results we get from the info bar.

password_manager::metrics_util::UIDismissalReason infobar_response_;