[Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr

components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/sync/browser/sync_credentials_filter.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
@@ skipping 78 matching lines @@
     enum { FORM_FILTERED, FORM_NOT_FILTERED } is_form_filtered;
     enum { NO_HISTOGRAM, HISTOGRAM_REPORTED } histogram_reported;
   };
 
   // Flag for creating a PasswordFormManager, deciding its IsNewLogin() value.
   enum class LoginState { NEW, EXISTING };
 
   CredentialsFilterTest()
       : password_manager_(&client_),
         pending_(SimpleGaiaForm("user@gmail.com")),
-        form_manager_(&password_manager_,
-                      &client_,
-                      driver_.AsWeakPtr(),
-                      pending_,
-                      base::MakeUnique<StubFormSaver>(),
-                      &fetcher_),
+        form_manager_(base::MakeRefCounted<PasswordFormManager>(
+            &password_manager_,
+            &client_,
+            driver_.AsWeakPtr(),
+            pending_,
+            base::MakeUnique<StubFormSaver>(),
+            &fetcher_)),
         filter_(&client_,
                 base::Bind(&SyncUsernameTestBase::sync_service,
                            base::Unretained(this)),
                 base::Bind(&SyncUsernameTestBase::signin_manager,
                            base::Unretained(this))) {
     fetcher_.Fetch();
   }
 
   void CheckFilterResultsTestCase(const TestCase& test_case) {
     SetSyncingPasswords(test_case.password_sync == TestCase::SYNCING_PASSWORDS);
@@ skipping 16 matching lines @@
   // Makes |form_manager_| provisionally save |pending_|. Depending on
   // |login_state| being NEW or EXISTING, prepares |form_manager_| in a state in
   // which |pending_| looks like a new or existing credential, respectively.
   void SavePending(LoginState login_state) {
     std::vector<const PasswordForm*> matches;
     if (login_state == LoginState::EXISTING) {
       matches.push_back(&pending_);
     }
     fetcher_.SetNonFederated(matches, 0u);
 
-    form_manager_.ProvisionallySave(
+    form_manager_->ProvisionallySave(
         pending_, PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);
   }
 
  protected:
   FakePasswordManagerClient client_;
   PasswordManager password_manager_;
   StubPasswordManagerDriver driver_;
   PasswordForm pending_;
   FakeFormFetcher fetcher_;
-  PasswordFormManager form_manager_;
+  scoped_refptr<PasswordFormManager> form_manager_;
 
   SyncCredentialsFilter filter_;
 };
 
 TEST_F(CredentialsFilterTest, FilterResults_AllowAll) {
   // By default, sync username is not filtered at all.
   const TestCase kTestCases[] = {
       // Reauth URL, not sync username.
       {TestCase::SYNCING_PASSWORDS, SimpleGaiaForm("user@example.org"),
        "another_user@example.org",
@@ skipping 117 matching lines @@
     CheckFilterResultsTestCase(kTestCases[i]);
   }
 }
 
 TEST_F(CredentialsFilterTest, ReportFormLoginSuccess_ExistingSyncCredentials) {
   FakeSigninAs("user@gmail.com");
   SetSyncingPasswords(true);
 
   base::UserActionTester tester;
   SavePending(LoginState::EXISTING);
-  filter_.ReportFormLoginSuccess(form_manager_);
+  filter_.ReportFormLoginSuccess(*form_manager_);
   EXPECT_EQ(1, tester.GetActionCount(kFilledAndLoginActionName));
 }
 
 TEST_F(CredentialsFilterTest, ReportFormLoginSuccess_NewSyncCredentials) {
   FakeSigninAs("user@gmail.com");
   SetSyncingPasswords(true);
 
   base::UserActionTester tester;
   SavePending(LoginState::NEW);
-  filter_.ReportFormLoginSuccess(form_manager_);
+  filter_.ReportFormLoginSuccess(*form_manager_);
   EXPECT_EQ(0, tester.GetActionCount(kFilledAndLoginActionName));
 }
 
 TEST_F(CredentialsFilterTest, ReportFormLoginSuccess_GAIANotSyncCredentials) {
   const char kOtherUsername[] = "other_user@gmail.com";
   FakeSigninAs(kOtherUsername);
   ASSERT_NE(pending_.username_value, base::ASCIIToUTF16(kOtherUsername));
   SetSyncingPasswords(true);
 
   base::UserActionTester tester;
   SavePending(LoginState::EXISTING);
-  filter_.ReportFormLoginSuccess(form_manager_);
+  filter_.ReportFormLoginSuccess(*form_manager_);
   EXPECT_EQ(0, tester.GetActionCount(kFilledAndLoginActionName));
 }
 
 TEST_F(CredentialsFilterTest, ReportFormLoginSuccess_NotGAIACredentials) {
   pending_ = SimpleNonGaiaForm("user@gmail.com");
   FakeSigninAs("user@gmail.com");
   SetSyncingPasswords(true);
 
   base::UserActionTester tester;
   SavePending(LoginState::EXISTING);
-  filter_.ReportFormLoginSuccess(form_manager_);
+  filter_.ReportFormLoginSuccess(*form_manager_);
   EXPECT_EQ(0, tester.GetActionCount(kFilledAndLoginActionName));
 }
 
 TEST_F(CredentialsFilterTest, ReportFormLoginSuccess_NotSyncing) {
   FakeSigninAs("user@gmail.com");
   SetSyncingPasswords(false);
 
   base::UserActionTester tester;
   SavePending(LoginState::EXISTING);
-  filter_.ReportFormLoginSuccess(form_manager_);
+  filter_.ReportFormLoginSuccess(*form_manager_);
   EXPECT_EQ(0, tester.GetActionCount(kFilledAndLoginActionName));
 }
 
 TEST_F(CredentialsFilterTest, ShouldSave_NotSyncCredential) {
   PasswordForm form = SimpleGaiaForm("user@example.org");
 
   ASSERT_NE("user@example.org",
             signin_manager()->GetAuthenticatedAccountInfo().email);
   SetSyncingPasswords(true);
   EXPECT_TRUE(filter_.ShouldSave(form));
@@ skipping 32 matching lines @@
 
   FakeSigninAs("test1@gmail.com");
 
   results = filter_.FilterResults(std::move(results));
 
   ASSERT_EQ(1u, results.size());
   EXPECT_EQ(SimpleGaiaForm("test2@gmail.com"), *results[0]);
 }
 
 }  // namespace password_manager