[Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr

components/password_manager/core/browser/password_form_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
 
+#include <base/memory/ref_counted.h>

[vasilii, 2017/05/29 13:15:48]

Should go down

[kolos1, 2017/05/29 15:47:06]

Done.

 #include <stdint.h>
 
 #include <map>
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/optional.h"
 #include "base/strings/string16.h"
 #include "build/build_config.h"
 #include "components/autofill/core/browser/field_types.h"
 #include "components/autofill/core/browser/form_structure.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/core/browser/form_fetcher.h"
 #include "components/password_manager/core/browser/password_manager_driver.h"
 #include "components/password_manager/core/browser/password_store.h"
 
 using autofill::FormData;
 using autofill::FormStructure;
+using base::RefCounted;

[vasilii, 2017/05/29 13:15:48]

Seems mostly not used.

[kolos1, 2017/05/29 15:47:06]

Removed.

 
 namespace password_manager {
 
 class FormSaver;
 class PasswordManager;
 class PasswordManagerClient;
 
 // A map from field names to field types.
 using FieldTypeMap = std::map<base::string16, autofill::ServerFieldType>;
 
 // This class helps with filling the observed form (both HTML and from HTTP
 // auth) and with saving/updating the stored information about it.
-class PasswordFormManager : public FormFetcher::Consumer {
+class PasswordFormManager : public FormFetcher::Consumer,
+                            public RefCounted<PasswordFormManager> {
  public:
   // |password_manager| owns |this|, |client| and |driver| serve to
   // communicate with embedder, |observed_form| is the associated form |this|
   // is managing, |form_saver| is used to save/update the form and
   // |form_fetcher| to get saved data about the form. |form_fetcher| must not be
   // destroyed before |this|.
   //
   // TODO(crbug.com/621355): So far, |form_fetcher| can be null. In that case
   // |this| creates an instance of it itself (meant for production code). Once
   // the fetcher is shared between PasswordFormManager instances, it will be
   // required that |form_fetcher| is not null.
   PasswordFormManager(PasswordManager* password_manager,
                       PasswordManagerClient* client,
                       const base::WeakPtr<PasswordManagerDriver>& driver,
                       const autofill::PasswordForm& observed_form,
                       std::unique_ptr<FormSaver> form_saver,
                       FormFetcher* form_fetcher);
-  ~PasswordFormManager() override;
 
   // Flags describing the result of comparing two forms as performed by
   // DoesMatch. Individual flags are only relevant for HTML forms, but
   // RESULT_COMPLETE_MATCH will also be returned to indicate non-HTML forms
   // completely matching.
   // The ordering of these flags is important. Larger matches are more
   // preferred than lower matches. That is, since RESULT_HTML_ATTRIBUTES_MATCH
   // is greater than RESULT_ACTION_MATCH, a match of only attributes and not
   // actions will be preferred to one of actions and not attributes.
   enum MatchResultFlags {
@@ skipping 178 matching lines @@
   // owned by the associated FormFetcher. This does not cause removing |this| as
   // a consumer of |form_fetcher_|.
   void ResetStoredMatches();
 
   // Takes ownership of |fetcher|. If |fetcher| is different from the current
   // |form_fetcher_| then also resets matches stored from the old fetcher and
   // adds itself as a consumer of the new one.
   void GrabFetcher(std::unique_ptr<FormFetcher> fetcher);
 
  protected:
+  ~PasswordFormManager() override;
+
   // FormFetcher::Consumer:
   void ProcessMatches(
       const std::vector<const autofill::PasswordForm*>& non_federated,
       size_t filtered_count) override;
 
  private:
+  friend class base::RefCounted<PasswordFormManager>;

[vasilii, 2017/05/29 13:15:48]

What is the point in making a base class friend?

[kolos1, 2017/05/29 15:47:06]

It is required for using RefCounted
(https://cs.chromium.org/chromium/src/base/memory/ref_counted.h?rcl=a71587c587...).

+
   // ManagerAction - What does the manager do with this form? Either it
   // fills it, or it doesn't. If it doesn't fill it, that's either
   // because it has no match or it is disabled via the AUTOCOMPLETE=off
   // attribute. Note that if we don't have an exact match, we still provide
   // candidates that the user may end up choosing.
   enum ManagerAction {
     kManagerActionNone = 0,
     kManagerActionAutofilled,
     kManagerActionBlacklisted_Obsolete,
     kManagerActionMax
@@ skipping 369 matching lines @@
   // True if the main frame's visible URL, at the time this PasswordFormManager
   // was created, is secure.
   bool is_main_frame_secure_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_