[Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr

components/password_manager/core/browser/credential_manager_password_form_manager_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/credential_manager_password_form_manager.h"
+#include <base/memory/ref_counted.h>

[vasilii, 2017/05/29 13:15:48]

Improper place and style for the include (no <>)

[kolos1, 2017/05/29 15:47:06]

Done.

 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/core/browser/fake_form_fetcher.h"
 #include "components/password_manager/core/browser/stub_form_saver.h"
@@ skipping 27 matching lines @@
   StubPasswordManagerClient client_;
   StubPasswordManagerDriver driver_;
 
   DISALLOW_COPY_AND_ASSIGN(CredentialManagerPasswordFormManagerTest);
 };
 
 // Test that aborting early does not cause use after free.
 TEST_F(CredentialManagerPasswordFormManagerTest, AbortEarly) {
   PasswordForm observed_form;
   MockDelegate delegate;
-  auto form_manager = base::MakeUnique<CredentialManagerPasswordFormManager>(
-      &client_, driver_.AsWeakPtr(), observed_form,
-      base::MakeUnique<PasswordForm>(observed_form), &delegate,
-      base::MakeUnique<StubFormSaver>(), base::MakeUnique<FakeFormFetcher>());
+  auto form_manager =
+      base::MakeRefCounted<CredentialManagerPasswordFormManager>(
+          &client_, driver_.AsWeakPtr(), observed_form,
+          base::MakeUnique<PasswordForm>(observed_form), &delegate,
+          base::MakeUnique<StubFormSaver>(),
+          base::MakeUnique<FakeFormFetcher>());
 
-  auto deleter = [&form_manager]() { form_manager.reset(); };
+  auto deleter = [&form_manager]() { form_manager = nullptr; };
 
   // Simulate that the PasswordStore responded to the FormFetcher. As a result,
   // |form_manager| should call the delegate's OnProvisionalSaveComplete, which
   // in turn should delete |form_fetcher|.
   EXPECT_CALL(delegate, OnProvisionalSaveComplete()).WillOnce(Invoke(deleter));
   static_cast<FakeFormFetcher*>(form_manager->form_fetcher())
       ->SetNonFederated(std::vector<const PasswordForm*>(), 0u);
   // Check that |form_manager| was not deleted yet; doing so would have caused
   // use after free during SetNonFederated.
   EXPECT_TRUE(form_manager);
 
   base::RunLoop().RunUntilIdle();
 
   // Ultimately, |form_fetcher| should have been deleted. It just should happen
   // after it finishes executing.
   EXPECT_FALSE(form_manager);
 }
 
 }  // namespace password_manager