Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: components/password_manager/core/browser/credential_manager_password_form_manager.h

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PASSWORD_FOR M_MANAGER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PASSWORD_FOR M_MANAGER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PASSWORD_FOR M_MANAGER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PASSWORD_FOR M_MANAGER_H_
7 7
8 #include <base/memory/ref_counted.h>
8 #include "base/macros.h" 9 #include "base/macros.h"
9 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
10 #include "components/password_manager/core/browser/password_form_manager.h" 11 #include "components/password_manager/core/browser/password_form_manager.h"
11 12
12 namespace autofill { 13 namespace autofill {
13 struct PasswordForm; 14 struct PasswordForm;
14 } 15 }
15 16
16 namespace password_manager { 17 namespace password_manager {
17 18
(...skipping 21 matching lines...) Expand all
39 // 40 //
40 // This class does not take ownership of |delegate|. 41 // This class does not take ownership of |delegate|.
41 CredentialManagerPasswordFormManager( 42 CredentialManagerPasswordFormManager(
42 PasswordManagerClient* client, 43 PasswordManagerClient* client,
43 base::WeakPtr<PasswordManagerDriver> driver, 44 base::WeakPtr<PasswordManagerDriver> driver,
44 const autofill::PasswordForm& observed_form, 45 const autofill::PasswordForm& observed_form,
45 std::unique_ptr<autofill::PasswordForm> saved_form, 46 std::unique_ptr<autofill::PasswordForm> saved_form,
46 CredentialManagerPasswordFormManagerDelegate* delegate, 47 CredentialManagerPasswordFormManagerDelegate* delegate,
47 std::unique_ptr<FormSaver> form_saver, 48 std::unique_ptr<FormSaver> form_saver,
48 std::unique_ptr<FormFetcher> form_fetcher); 49 std::unique_ptr<FormFetcher> form_fetcher);
49 ~CredentialManagerPasswordFormManager() override;
50 50
51 void ProcessMatches( 51 void ProcessMatches(
52 const std::vector<const autofill::PasswordForm*>& non_federated, 52 const std::vector<const autofill::PasswordForm*>& non_federated,
53 size_t filtered_count) override; 53 size_t filtered_count) override;
54 54
55 protected:
56 ~CredentialManagerPasswordFormManager() override;
vasilii 2017/05/29 13:15:48 you should move the method in the cc file
kolos1 2017/05/29 15:47:06 Done.
57
55 private: 58 private:
56 // Calls OnProvisionalSaveComplete on |delegate_|. 59 // Calls OnProvisionalSaveComplete on |delegate_|.
57 void NotifyDelegate(); 60 void NotifyDelegate();
58 61
59 CredentialManagerPasswordFormManagerDelegate* delegate_; 62 CredentialManagerPasswordFormManagerDelegate* delegate_;
60 std::unique_ptr<autofill::PasswordForm> saved_form_; 63 std::unique_ptr<autofill::PasswordForm> saved_form_;
61 64
62 base::WeakPtrFactory<CredentialManagerPasswordFormManager> weak_factory_; 65 base::WeakPtrFactory<CredentialManagerPasswordFormManager> weak_factory_;
63 66
64 DISALLOW_COPY_AND_ASSIGN(CredentialManagerPasswordFormManager); 67 DISALLOW_COPY_AND_ASSIGN(CredentialManagerPasswordFormManager);
65 }; 68 };
66 69
67 } // namespace password_manager 70 } // namespace password_manager
68 71
69 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PASSWORD_ FORM_MANAGER_H_ 72 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_CREDENTIAL_MANAGER_PASSWORD_ FORM_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698