Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_test.cc

Issue 2900693002: [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/passwords/manage_passwords_test.h" 5 #include "chrome/browser/ui/passwords/manage_passwords_test.h"
6 6
7 #include <map> 7 #include <map>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 } 60 }
61 61
62 void ManagePasswordsTest::SetupManagingPasswords() { 62 void ManagePasswordsTest::SetupManagingPasswords() {
63 std::map<base::string16, const autofill::PasswordForm*> map; 63 std::map<base::string16, const autofill::PasswordForm*> map;
64 map.insert(std::make_pair(base::ASCIIToUTF16(kTestUsername), test_form())); 64 map.insert(std::make_pair(base::ASCIIToUTF16(kTestUsername), test_form()));
65 GetController()->OnPasswordAutofilled(map, map.begin()->second->origin, 65 GetController()->OnPasswordAutofilled(map, map.begin()->second->origin,
66 nullptr); 66 nullptr);
67 } 67 }
68 68
69 void ManagePasswordsTest::SetupPendingPassword() { 69 void ManagePasswordsTest::SetupPendingPassword() {
70 std::unique_ptr<password_manager::PasswordFormManager> test_form_manager( 70 scoped_refptr<password_manager::PasswordFormManager> test_form_manager(
71 new password_manager::PasswordFormManager( 71 new password_manager::PasswordFormManager(
72 nullptr, &client_, driver_.AsWeakPtr(), *test_form(), 72 nullptr, &client_, driver_.AsWeakPtr(), *test_form(),
73 base::WrapUnique(new password_manager::StubFormSaver), &fetcher_)); 73 base::WrapUnique(new password_manager::StubFormSaver), &fetcher_));
74 fetcher_.SetNonFederated(std::vector<const autofill::PasswordForm*>(), 0u); 74 fetcher_.SetNonFederated(std::vector<const autofill::PasswordForm*>(), 0u);
75 GetController()->OnPasswordSubmitted(std::move(test_form_manager)); 75 GetController()->OnPasswordSubmitted(std::move(test_form_manager));
76 } 76 }
77 77
78 void ManagePasswordsTest::SetupAutomaticPassword() { 78 void ManagePasswordsTest::SetupAutomaticPassword() {
79 std::unique_ptr<password_manager::PasswordFormManager> test_form_manager( 79 scoped_refptr<password_manager::PasswordFormManager> test_form_manager(
80 new password_manager::PasswordFormManager( 80 new password_manager::PasswordFormManager(
81 nullptr, &client_, driver_.AsWeakPtr(), *test_form(), 81 nullptr, &client_, driver_.AsWeakPtr(), *test_form(),
82 base::WrapUnique(new password_manager::StubFormSaver), &fetcher_)); 82 base::WrapUnique(new password_manager::StubFormSaver), &fetcher_));
83 fetcher_.SetNonFederated(std::vector<const autofill::PasswordForm*>(), 0u); 83 fetcher_.SetNonFederated(std::vector<const autofill::PasswordForm*>(), 0u);
84 GetController()->OnAutomaticPasswordSave(std::move(test_form_manager)); 84 GetController()->OnAutomaticPasswordSave(std::move(test_form_manager));
85 } 85 }
86 86
87 void ManagePasswordsTest::SetupAutoSignin( 87 void ManagePasswordsTest::SetupAutoSignin(
88 std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials) { 88 std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials) {
89 ASSERT_FALSE(local_credentials.empty()); 89 ASSERT_FALSE(local_credentials.empty());
90 GURL origin = local_credentials[0]->origin; 90 GURL origin = local_credentials[0]->origin;
91 GetController()->OnAutoSignin(std::move(local_credentials), origin); 91 GetController()->OnAutoSignin(std::move(local_credentials), origin);
92 } 92 }
93 93
94 std::unique_ptr<base::HistogramSamples> ManagePasswordsTest::GetSamples( 94 std::unique_ptr<base::HistogramSamples> ManagePasswordsTest::GetSamples(
95 const char* histogram) { 95 const char* histogram) {
96 // Ensure that everything has been properly recorded before pulling samples. 96 // Ensure that everything has been properly recorded before pulling samples.
97 content::RunAllPendingInMessageLoop(); 97 content::RunAllPendingInMessageLoop();
98 return histogram_tester_.GetHistogramSamplesSinceCreation(histogram); 98 return histogram_tester_.GetHistogramSamplesSinceCreation(histogram);
99 } 99 }
100 100
101 PasswordsClientUIDelegate* ManagePasswordsTest::GetController() { 101 PasswordsClientUIDelegate* ManagePasswordsTest::GetController() {
102 return PasswordsClientUIDelegateFromWebContents( 102 return PasswordsClientUIDelegateFromWebContents(
103 browser()->tab_strip_model()->GetActiveWebContents()); 103 browser()->tab_strip_model()->GetActiveWebContents());
104 } 104 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698