src/regexp/ia32/regexp-macro-assembler-ia32.cc - Issue 2900683002: [compiler] Delay allocation of code-embedded heap numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/regexp/ia32/regexp-macro-assembler-ia32.cc

Issue 2900683002: [compiler] Delay allocation of code-embedded heap numbers. (Closed)

Patch Set: Fix rebase. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/regexp/ia32/regexp-macro-assembler-ia32.cc

diff --git a/src/regexp/ia32/regexp-macro-assembler-ia32.cc b/src/regexp/ia32/regexp-macro-assembler-ia32.cc

index c279304777972bc9e7b7c13f2251b210ae1a9b6b..35008b7b8a349ed6fbedf1115c8d23833d1dcae7 100644

--- a/src/regexp/ia32/regexp-macro-assembler-ia32.cc

+++ b/src/regexp/ia32/regexp-macro-assembler-ia32.cc

@@ -932,7 +932,7 @@ Handle<HeapObject> RegExpMacroAssemblerIA32::GetCode(Handle<String> source) {

}

CodeDesc code_desc;

- masm_->GetCode(&code_desc);

+ masm_->GetCode(masm_->isolate(), &code_desc);

Handle<Code> code =

isolate()->factory()->NewCode(code_desc,

Code::ComputeFlags(Code::REGEXP),