src/regexp/x64/regexp-macro-assembler-x64.cc - Issue 2900683002: [compiler] Delay allocation of code-embedded heap numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/regexp/x64/regexp-macro-assembler-x64.cc

Issue 2900683002: [compiler] Delay allocation of code-embedded heap numbers. (Closed)

Patch Set: Again. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/regexp/x64/regexp-macro-assembler-x64.cc

diff --git a/src/regexp/x64/regexp-macro-assembler-x64.cc b/src/regexp/x64/regexp-macro-assembler-x64.cc

index 8c51233e29594c0506d8812170525680d4295fc7..9b0352d863fd0f12d860481bfc467326766ea955 100644

--- a/src/regexp/x64/regexp-macro-assembler-x64.cc

+++ b/src/regexp/x64/regexp-macro-assembler-x64.cc

@@ -1005,8 +1005,8 @@ Handle<HeapObject> RegExpMacroAssemblerX64::GetCode(Handle<String> source) {

FixupCodeRelativePositions();

CodeDesc code_desc;

- masm_.GetCode(&code_desc);

Isolate* isolate = this->isolate();

+ masm_.GetCode(isolate, &code_desc);

Handle<Code> code = isolate->factory()->NewCode(

code_desc, Code::ComputeFlags(Code::REGEXP),

masm_.CodeObject());