third_party/WebKit/Source/core/layout/LayoutInline.cpp - Issue 2900633003: Make TextEmphasisMark an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutInline.cpp

Issue 2900633003: Make TextEmphasisMark an enum class. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutInline.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutInline.cpp b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

index 2cbe2e2beb2b07a9640d1bc24e7407fc75563084..3c3c8fdd7f0d788628b74b37c19222456a469c47 100644

--- a/third_party/WebKit/Source/core/layout/LayoutInline.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

@@ -230,7 +230,7 @@ void LayoutInline::UpdateAlwaysCreateLineBoxes(bool full_layout) {

(parent_layout_inline &&

parent_style.VerticalAlign() != EVerticalAlign::kBaseline) ||

Style()->VerticalAlign() != EVerticalAlign::kBaseline ||

- Style()->GetTextEmphasisMark() != kTextEmphasisMarkNone ||

+ Style()->GetTextEmphasisMark() != TextEmphasisMark::kNone ||

(check_fonts &&

(!StyleRef().HasIdenticalAscentDescentAndLineGap(parent_style) ||

parent_style.LineHeight() != StyleRef().LineHeight()));