Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js |
| index 64bbd62e9c75247ecefe8aa3f3a8b4e667dcb122..fcd97b112761c18612420bedff465e5965ed9fb9 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js |
| @@ -340,7 +340,6 @@ SDK.NetworkDispatcher = class { |
| /** |
| * @override |
| * @param {!Protocol.Network.RequestId} requestId |
| - * @param {!Protocol.Page.FrameId} frameId |
| * @param {!Protocol.Network.LoaderId} loaderId |
| * @param {string} documentURL |
| * @param {!Protocol.Network.Request} request |
| @@ -349,28 +348,21 @@ SDK.NetworkDispatcher = class { |
| * @param {!Protocol.Network.Initiator} initiator |
| * @param {!Protocol.Network.Response=} redirectResponse |
| * @param {!Protocol.Page.ResourceType=} resourceType |
| + * @param {!Protocol.Page.FrameId=} frameId |
| */ |
| requestWillBeSent( |
| - requestId, |
| - frameId, |
| - loaderId, |
| - documentURL, |
| - request, |
| - time, |
| - wallTime, |
| - initiator, |
| - redirectResponse, |
| - resourceType) { |
| + requestId, loaderId, documentURL, request, time, wallTime, initiator, redirectResponse, resourceType, frameId) { |
| var networkRequest = this._inflightRequestsById[requestId]; |
| if (networkRequest) { |
| // FIXME: move this check to the backend. |
| if (!redirectResponse) |
| return; |
| - this.responseReceived(requestId, frameId, loaderId, time, Protocol.Page.ResourceType.Other, redirectResponse); |
| + this.responseReceived(requestId, loaderId, time, Protocol.Page.ResourceType.Other, redirectResponse, frameId); |
| networkRequest = this._appendRedirect(requestId, time, request.url); |
| this._manager.dispatchEventToListeners(SDK.NetworkManager.Events.RequestRedirected, networkRequest); |
| } else { |
| - networkRequest = this._createNetworkRequest(requestId, frameId, loaderId, request.url, documentURL, initiator); |
| + networkRequest = |
| + this._createNetworkRequest(requestId, frameId ? frameId : '', loaderId, request.url, documentURL, initiator); |
|
dgozman
2017/06/28 22:50:32
nit: frameId || ''
horo
2017/06/29 02:14:28
Done.
|
| } |
| networkRequest.hasNetworkData = true; |
| this._updateNetworkRequestWithRequest(networkRequest, request); |
| @@ -396,19 +388,19 @@ SDK.NetworkDispatcher = class { |
| /** |
| * @override |
| * @param {!Protocol.Network.RequestId} requestId |
| - * @param {!Protocol.Page.FrameId} frameId |
| * @param {!Protocol.Network.LoaderId} loaderId |
| * @param {!Protocol.Network.Timestamp} time |
| * @param {!Protocol.Page.ResourceType} resourceType |
| * @param {!Protocol.Network.Response} response |
| + * @param {!Protocol.Page.FrameId=} frameId |
| */ |
| - responseReceived(requestId, frameId, loaderId, time, resourceType, response) { |
| + responseReceived(requestId, loaderId, time, resourceType, response, frameId) { |
| var networkRequest = this._inflightRequestsById[requestId]; |
| if (!networkRequest) { |
| // We missed the requestWillBeSent. |
| var eventData = {}; |
| eventData.url = response.url; |
| - eventData.frameId = frameId; |
| + eventData.frameId = frameId ? frameId : ''; |
|
dgozman
2017/06/28 22:50:32
ditto
horo
2017/06/29 02:14:28
Done.
|
| eventData.loaderId = loaderId; |
| eventData.resourceType = resourceType; |
| eventData.mimeType = response.mimeType; |