chrome/browser/ui/browser_commands.cc - Issue 2900603003: Successful translation erroneously reported on page with too little text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 2900603003: Successful translation erroneously reported on page with too little text (Closed)

Patch Set: Fixed a nit Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_commands.cc

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc

index 54582710f9eeabe66591d594472edeb84fde23ee..07d498e465cf2cdb07c32690ea6c948c621fefbb 100644

--- a/chrome/browser/ui/browser_commands.cc

+++ b/chrome/browser/ui/browser_commands.cc

@@ -864,6 +864,8 @@ void Translate(Browser* browser) {

if (chrome_translate_client) {

if (chrome_translate_client->GetLanguageState().translation_pending())

step = translate::TRANSLATE_STEP_TRANSLATING;

+ else if (chrome_translate_client->GetLanguageState().translation_error())

+ step = translate::TRANSLATE_STEP_TRANSLATE_ERROR;

else if (chrome_translate_client->GetLanguageState().IsPageTranslated())

step = translate::TRANSLATE_STEP_AFTER_TRANSLATE;

}