Network service: Safe browsing check for sub-resources from renderer.

chrome/common/safe_browsing.mojom

Index: chrome/common/safe_browsing.mojom
diff --git a/chrome/common/safe_browsing.mojom b/chrome/common/safe_browsing.mojom
new file mode 100644
index 0000000000000000000000000000000000000000..875ce966ef5db5d9fa3c43543a054b0dfab90625
--- /dev/null
+++ b/chrome/common/safe_browsing.mojom
@@ -0,0 +1,29 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module chrome.mojom;
+
+import "content/public/common/resource_type.mojom";
+import "url/mojo/url.mojom";
+
+interface SafeBrowsing {
+  // Queries safe browsing whether |url| is safe to load, and creates a
+  // SafeBrowsingUrlChecker interface.
+  // This checker interface should be used (and only used) for subsequent checks
+  // of redirects, so that the server side could keep track of the redirect
+  // chain. Disconnecting the checker interface cancels on-going URL checks.
+  // Please note that in that case if the check started by this method hasn't
+  // completed yet, it will also be canceled and return true as if the URL is
+  // safe.
+  CreateCheckerAndCheck(

[Nathan Parker, 2017/05/31 17:17:06]

Naming and/or comment suggestion:

I think we should state more specifically what this is checking against.

The SafeBrowsingDatabase::CheckBrowseUrl() checks against Safe Browsing's
Malware, Phishing, and UwS blacklists.  We could state that here, or just
mention that it uses the above function to determine if a URL is "safe."

If we wanted to add additional kinds of checks (such as... for
subresource-filtering of malicious ads, or a whitelist that'd prevent certain
other checks), would we add another method here? If so, then maybe we should
start with a more specific name.  The CheckUrl() below could be
"CheckBrowseUrl()" so later we could add "CheckWhitelistUrl()" or
"CheckSubresourceBlockingUrl()" or some such.

[yzshen1, 2017/05/31 23:34:44]

Updated the comments.

I am thinking maybe we could have a CheckType enum as parameter in that case? We
could add new methods as well, but we will need to add to both SafeBrowsing and
SafeBrowsingUrlChecker. That is slightly more annoying.

Because we don't need to consider backward-compatibility, we could change this
interface when the need emerges. If you don't mind, I would like to leave it as
it is. WDYT?

+      int32 render_frame_id,
+      SafeBrowsingUrlChecker& request,
+      url.mojom.Url url,
+      int32 load_flags,
+      content.mojom.ResourceType resource_type) => (bool result);
+};
+
+interface SafeBrowsingUrlChecker {
+  CheckUrl(url.mojom.Url url) => (bool result);
+};