Fix type inference of factory constructor invocations.

Fix type inference of factory constructor invocations.

Factory constructors are represented as static methods with dynamic
return type; in order to type infer them properly we must use the type
of the enclosing class as the return type (with type parameters
substituted appropriately).

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/4b9485db73e2bb8179c1a37750c20f8123ccd22c

[Paul Berry, 2017-05-21 22:51:36]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-05-22 05:27:33]

LGTM

https://codereview.chromium.org/2900553003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right):

https://codereview.chromium.org/2900553003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:298: new Set();
Do we need this statement?

[Paul Berry, 2017-05-22 18:09:57]

https://codereview.chromium.org/2900553003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right):

https://codereview.chromium.org/2900553003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:298: new Set();
On 2017/05/22 05:27:33, scheglov wrote:
> Do we need this statement?

Oops, that was a mistake.  Removed.

[Paul Berry, 2017-05-22 18:18:37]

Description was changed from

==========
Fix type inference of factory constructor invocations.

Factory constructors are represented as static methods with dynamic
return type; in order to type infer them properly we must use the type
of the enclosing class as the return type (with type parameters
substituted appropriately).
==========

to

==========
Fix type inference of factory constructor invocations.

Factory constructors are represented as static methods with dynamic
return type; in order to type infer them properly we must use the type
of the enclosing class as the return type (with type parameters
substituted appropriately).

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4b9485db73e2bb8179c1a37750c20f8123ccd22c
==========

[Paul Berry, 2017-05-22 18:18:38]

Committed patchset #1 (id:1) manually as
4b9485db73e2bb8179c1a37750c20f8123ccd22c (presubmit successful).