Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Unified Diff: mojo/public/cpp/bindings/lib/multiplex_router.h

Issue 2900543002: Mojo C++ bindings: introduce mojo::internal::deque and use it in MultiplexRouter. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/multiplex_router.h
diff --git a/mojo/public/cpp/bindings/lib/multiplex_router.h b/mojo/public/cpp/bindings/lib/multiplex_router.h
index cac138bcb79b4c635a98176ecd2213dc36a1c453..b44b9ca882e6faad18012c0af22c70d71813190e 100644
--- a/mojo/public/cpp/bindings/lib/multiplex_router.h
+++ b/mojo/public/cpp/bindings/lib/multiplex_router.h
@@ -7,7 +7,6 @@
#include <stdint.h>
-#include <deque>
#include <map>
#include <memory>
#include <string>
@@ -26,6 +25,7 @@
#include "mojo/public/cpp/bindings/connector.h"
#include "mojo/public/cpp/bindings/filter_chain.h"
#include "mojo/public/cpp/bindings/interface_id.h"
+#include "mojo/public/cpp/bindings/lib/pointer_deque.h"
#include "mojo/public/cpp/bindings/message_header_validator.h"
#include "mojo/public/cpp/bindings/pipe_control_message_handler.h"
#include "mojo/public/cpp/bindings/pipe_control_message_handler_delegate.h"
@@ -253,9 +253,9 @@ class MOJO_CPP_BINDINGS_EXPORT MultiplexRouter
std::map<InterfaceId, scoped_refptr<InterfaceEndpoint>> endpoints_;
uint32_t next_interface_id_value_;
- std::deque<std::unique_ptr<Task>> tasks_;
+ PointerDeque<Task, true> tasks_;
// It refers to tasks in |tasks_| and doesn't own any of them.
- std::map<InterfaceId, std::deque<Task*>> sync_message_tasks_;
+ std::map<InterfaceId, PointerDeque<Task, false>> sync_message_tasks_;
bool posted_to_process_tasks_;
scoped_refptr<base::SingleThreadTaskRunner> posted_to_task_runner_;

Powered by Google App Engine
This is Rietveld 408576698