Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc

Issue 2900533002: Add an async ReadTrailers method to QuicChromiumClientStream::Handle (Closed)
Patch Set: Fix comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
diff --git a/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc b/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
index f02458b86f8ffb0f22b0fa1ea5cc857ef0f876c0..d4c0d028ca871c69d925203d9496bc12dc56bb66 100644
--- a/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
+++ b/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
@@ -317,9 +317,12 @@ class DeleteStreamDelegate : public TestDelegateBase {
void OnTrailersReceived(const SpdyHeaderBlock& trailers) override {
DCHECK_NE(ON_HEADERS_RECEIVED, phase_);
DCHECK_NE(ON_DATA_READ, phase_);
+ // Make a copy of |response_headers| before the stream is deleted, since
+ // the headers are owned by the stream.
+ SpdyHeaderBlock trailers_copy = trailers.Clone();
if (phase_ == ON_TRAILERS_RECEIVED)
DeleteStream();
- TestDelegateBase::OnTrailersReceived(trailers);
+ TestDelegateBase::OnTrailersReceived(trailers_copy);
}
void OnFailed(int error) override {
« no previous file with comments | « net/quic/chromium/bidirectional_stream_quic_impl.cc ('k') | net/quic/chromium/quic_chromium_client_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698