Issue 290043006: Add whitelist for app.window.shape permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 290043006: Add whitelist for app.window.shape permission. (Closed)

Created:
6 years, 7 months ago by garykac

Modified:
6 years, 7 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add whitelist for app.window.shape permission. This whitelist matches the current list in app_current_window_internal_api.cc for SetShape(). That whitelist will be removed in a separate cl. BUG=374433, 323773, 356200, 327507, 354258 R=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271140

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -4 lines)			Patch
	M	chrome/common/extensions/api/_permission_features.json	View	1	1 chunk	+40 lines, -4 lines	0 comments	Download

Total messages: 6 (0 generated)

not at google - send to devlin

Please add a bug and go through the process in the link at the top ...

6 years, 7 months ago (2014-05-16 22:13:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/290043006/20001

6 years, 7 months ago (2014-05-16 23:33:49 UTC) #5

garykac

6 years, 7 months ago (2014-05-17 01:36:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r271140 (presubmit successful).