Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 290043003: Revert of Use ExtensionRegistryObserver (Closed)

Created:
6 years, 7 months ago by limasdf
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, James Su, extensions-reviews_chromium.org, not at google - send to devlin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Use ExtensionRegistryObserver instead of deprecated extension notification from autocomplete (https://codereview.chromium.org/271393003/) Reason for revert: Crash is reported. See https://code.google.com/p/chromium/issues/detail?id=373624 Original issue's description: > Use extensions::ExtensionRegistryObserver instead of deprecated extension notification from autocomplete > > R=pkasting@chromium.org > CC=kalman@chromium.org > BUG=354046, 354458 > TEST=unit_tests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270268 TBR=pkasting@chromium.org,kalman@chromium.org NOTREECHECKS=true NOTRY=true BUG=354046, 354458 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -76 lines) Patch
M chrome/browser/autocomplete/extension_app_provider.h View 2 chunks +1 line, -17 lines 0 comments Download
M chrome/browser/autocomplete/extension_app_provider.cc View 2 chunks +5 lines, -17 lines 0 comments Download
M chrome/browser/autocomplete/extension_app_provider_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend.h View 5 chunks +1 line, -18 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend.cc View 5 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
limasdf
Created Revert of Use ExtensionRegistryObserver instead of deprecated extension notification from autocomplete
6 years, 7 months ago (2014-05-15 18:31:30 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 18:33:22 UTC) #2
Peter Kasting
RSLGTM
6 years, 7 months ago (2014-05-15 18:33:39 UTC) #3
Peter Kasting
The CQ bit was checked by pkasting@chromium.org
6 years, 7 months ago (2014-05-15 18:33:54 UTC) #4
limasdf
On 2014/05/15 18:33:54, Peter Kasting wrote: > The CQ bit was checked by mailto:pkasting@chromium.org sorry ...
6 years, 7 months ago (2014-05-15 18:34:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/290043003/1
6 years, 7 months ago (2014-05-15 18:36:18 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 19:03:45 UTC) #7
Message was sent while issue was closed.
Change committed as 270764

Powered by Google App Engine
This is Rietveld 408576698