Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2900423003: Use origins instead of URLs in console messages about mixed content.

Created:
3 years, 7 months ago by alexmos
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use origins instead of URLs in console messages about mixed content. Specifically, use origins when the frame loading a resource and the frame with respect to which content is mixed are different. This avoids potential information disclosure with OOPIFs, and includes scenarios such as https://foo.com embedding an insecure subframe http://bar.com, or that insecure subframe further loading insecure subresources. It does *not* include the case where https://foo.com embeds insecure subresources, like <img src="http://foo.com/foo.jpg">. BUG=726178 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -34 lines) Patch
M content/browser/frame_host/mixed_content_navigation_throttle.cc View 3 chunks +28 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/active-subresource-in-iframe-blocked.https-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-css-image-with-reload-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-frame-in-data-iframe-in-main-frame-blocked-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-iframe-in-iframe-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-iframe-in-main-frame-allowed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-iframe-in-main-frame-blocked-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-iframe-with-hsts.https-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/nonwebby-scheme-in-iframe-allowed.https-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/strict-mode-image-in-frame-blocked.https-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.cpp View 4 chunks +22 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (5 generated)
arthursonzogni
3 years, 6 months ago (2017-05-29 15:23:04 UTC) #6
On 2017/05/25 03:10:07, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

I like it. FYI I ran the PlzNavigate TryBot
"linux_chromium_browser_side_navigation_rel".
One test is failing:
http/tests/security/mixedContent/insecure-iframe-with-hsts.https.html
The "line:18" is missing. This is because the source location of the main frame
is not transmitted to the sub-frame. This is expected because that is what this
CL does.

Powered by Google App Engine
This is Rietveld 408576698