Issue 29004: We allow Flash to popup windows in response to user gesture messages like WM_...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 29004: We allow Flash to popup windows in response to user gesture messages like WM_... (Closed)

Created:
11 years, 10 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

We allow Flash to popup windows in response to user gesture messages like WM_LBUTTONUP, etc. However we need to reset the popup stack in a timer, as Flash typically brings up these windows in a posted 0x401 message. This is on the same lines as the webkit plugin implementation. This fixes http://code.google.com/p/chromium/issues/detail?id=7850 Bug=7850 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10308

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	webkit/glue/plugins/webplugin_delegate_impl.cc	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

11 years, 10 months ago (2009-02-24 23:37:10 UTC) #2

lgtm

http://codereview.chromium.org/29004/diff/1/2
File webkit/glue/plugins/webplugin_delegate_impl.cc (right):

http://codereview.chromium.org/29004/diff/1/2#newcode46
Line 46: const int kWindowedPluginPopupTimerMs = 50;
need a brief comment here explaining why it's needed

Expand Messages | Collapse Messages