Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 29003: Make download manager treat mixed-case extensions the same as lower-case exte... (Closed)

Created:
9 years, 5 months ago by Evan Stade
Modified:
7 years, 1 month ago
Reviewers:
tony, jcampan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make download manager treat mixed-case extensions the same as lower-case extensions when judging whether a file is executable. Also, store known executable file extensions as narrow strings since they are all ASCII anyway. r=jcampan BUG=7455 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10246

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -87 lines) Patch
M chrome/browser/download/download_exe.cc View 1 2 1 chunk +84 lines, -84 lines 0 comments Download
M chrome/browser/download/download_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_manager.cc View 1 chunk +13 lines, -1 line 0 comments Download
M chrome/browser/download/download_util.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
9 years, 5 months ago (2009-02-24 00:57:59 UTC) #1
jcampan
http://codereview.chromium.org/29003/diff/1007/12 File chrome/browser/download/download_exe.cc (right): http://codereview.chromium.org/29003/diff/1007/12#newcode68 Line 68: "cp", It seems you removed by mistake ending ...
9 years, 5 months ago (2009-02-24 01:05:39 UTC) #2
Evan Stade
good catch http://codereview.chromium.org/29003/diff/1007/12 File chrome/browser/download/download_exe.cc (right): http://codereview.chromium.org/29003/diff/1007/12#newcode68 Line 68: "cp", On 2009/02/24 01:05:39, jcampan wrote: ...
9 years, 5 months ago (2009-02-24 01:12:18 UTC) #3
tony
It would be nice if there was a test for this. Could be in a ...
9 years, 5 months ago (2009-02-24 01:25:37 UTC) #4
jcampan
9 years, 5 months ago (2009-02-24 02:05:54 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698