Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2900263002: Use failedAt in more places (constants, universe) (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use failedAt in more places (constants, universe) TBR=sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a545c5c31fdee77dd776d5556581468c8c071702

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -111 lines) Patch
M pkg/compiler/lib/src/constants/constant_constructors.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/constants/evaluation.dart View 2 chunks +16 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/codegen_world_builder.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 1 chunk +1 line, -2 lines 1 comment Download
M pkg/compiler/lib/src/universe/selector.dart View 1 chunk +9 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 8 chunks +129 lines, -76 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
sra1
Committed patchset #1 (id:1) manually as a545c5c31fdee77dd776d5556581468c8c071702 (presubmit successful).
3 years, 7 months ago (2017-05-24 02:23:44 UTC) #2
Siggi Cherem (dart-lang)
3 years, 7 months ago (2017-05-24 16:03:29 UTC) #3
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/2900263002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/resolution_world_builder.dart (right):

https://codereview.chromium.org/2900263002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/resolution_world_builder.dart:633:
failedAt(element, 'Direct static use is not supported for resolution.');
odd that here was invariant and the line below was a throw. Should they match?

Powered by Google App Engine
This is Rietveld 408576698