Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: chrome/browser/resources/feedback/js/event_handler.js

Issue 2900253006: WebUI: Fix more violations of no-extra-semi lint rule. (Closed)
Patch Set: clang-format Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // <include src="data.js"> 5 // <include src="data.js">
6 6
7 /** 7 /**
8 * @type {number} 8 * @type {number}
9 * @const 9 * @const
10 */ 10 */
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 } 191 }
192 192
193 /** 193 /**
194 * Handles the event when the feedback UI window corresponding to this 194 * Handles the event when the feedback UI window corresponding to this
195 * FeedbackRequest instance is closed. 195 * FeedbackRequest instance is closed.
196 */ 196 */
197 onWindowClosed() { 197 onWindowClosed() {
198 if (!this.reportIsBeingSent_) 198 if (!this.reportIsBeingSent_)
199 this.isRequestCanceled_ = true; 199 this.isRequestCanceled_ = true;
200 } 200 }
201 }; 201 }
202 202
203 /** 203 /**
204 * Function to determine whether or not a given extension id is whitelisted to 204 * Function to determine whether or not a given extension id is whitelisted to
205 * invoke the feedback UI. If the extension is whitelisted, the callback to 205 * invoke the feedback UI. If the extension is whitelisted, the callback to
206 * start the Feedback UI will be called. 206 * start the Feedback UI will be called.
207 * @param {string} id the id of the sender extension. 207 * @param {string} id the id of the sender extension.
208 * @param {Function} startFeedbackCallback The callback function that will 208 * @param {Function} startFeedbackCallback The callback function that will
209 * will start the feedback UI. 209 * will start the feedback UI.
210 * @param {Object} feedbackInfo The feedback info object to pass to the 210 * @param {Object} feedbackInfo The feedback info object to pass to the
211 * start feedback UI callback. 211 * start feedback UI callback.
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 // Observe when the window is closed. 291 // Observe when the window is closed.
292 appWindow.onClosed.addListener(function() { 292 appWindow.onClosed.addListener(function() {
293 request.onWindowClosed(); 293 request.onWindowClosed();
294 }); 294 });
295 }); 295 });
296 } 296 }
297 297
298 chrome.runtime.onMessage.addListener(feedbackReadyHandler); 298 chrome.runtime.onMessage.addListener(feedbackReadyHandler);
299 chrome.runtime.onMessageExternal.addListener(requestFeedbackHandler); 299 chrome.runtime.onMessageExternal.addListener(requestFeedbackHandler);
300 chrome.feedbackPrivate.onFeedbackRequested.addListener(startFeedbackUI); 300 chrome.feedbackPrivate.onFeedbackRequested.addListener(startFeedbackUI);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698