Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1665)

Unified Diff: chrome/android/java/res/layout/password_entry_editor_interactive.xml

Issue 2900173002: Copy and view saved passwords. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/password_entry_editor_interactive.xml
diff --git a/chrome/android/java/res/layout/password_entry_editor_interactive.xml b/chrome/android/java/res/layout/password_entry_editor_interactive.xml
index 7a999b102c0fbba9f2f8812a09577f1c9988fedb..014fe390b63a6f9719cb5cee52d420a34e43f694 100644
--- a/chrome/android/java/res/layout/password_entry_editor_interactive.xml
+++ b/chrome/android/java/res/layout/password_entry_editor_interactive.xml
@@ -14,7 +14,7 @@
android:layout_height="wrap_content"
android:orientation="vertical"
android:title="@string/password_entry_editor_title">
-
+
<TextView
android:text="@string/password_entry_editor_site_title"
android:textColor="@color/google_blue_700"
@@ -24,12 +24,12 @@
android:layout_marginStart="15dp"
android:gravity="center_vertical"
android:textAppearance="?android:attr/textAppearanceMedium" />
-
+
<LinearLayout
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:orientation="horizontal">
-
+
<TextView
android:id="@+id/password_entry_editor_url"
android:textColor="@color/default_text_color"
@@ -38,24 +38,26 @@
android:layout_marginTop="10dp"
android:layout_marginStart="15dp"
android:textAppearance="?android:attr/textAppearanceMedium" />
-
+
<View
android:layout_width="0dp"
android:layout_height="0dp"
android:layout_weight="1" />
-
+
<ImageButton
- style="?android:attr/buttonStyleSmall"
+ android:id="@+id/password_entry_editor_copy_site"
+ android:background="@null"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="end"
android:layout_marginTop="10dp"
android:layout_marginEnd="15dp"
android:src="@drawable/ic_content_copy"
- android:contentDescription="@string/password_entry_editor_copy_stored_site" />
-
+ android:contentDescription="@string/password_entry_editor_copy_stored_site"
+ style="?android:attr/buttonStyleSmall" />
+
</LinearLayout>
-
+
<TextView
android:text="@string/password_entry_editor_username_title"
android:textColor="@color/google_blue_700"
@@ -65,12 +67,12 @@
android:layout_marginStart="15dp"
android:gravity="center_vertical"
android:textAppearance="?android:attr/textAppearanceMedium" />
-
+
<LinearLayout
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:orientation="horizontal">
-
+
<TextView
android:id="@+id/password_entry_editor_name"
android:textColor="@color/default_text_color"
@@ -79,24 +81,26 @@
android:layout_marginTop="10dp"
android:layout_marginStart="15dp"
android:textAppearance="?android:attr/textAppearanceMedium" />
-
+
<View
android:layout_width="0dp"
android:layout_height="0dp"
android:layout_weight="1" />
-
+
<ImageButton
- style="?android:attr/buttonStyleSmall"
+ android:id="@+id/password_entry_editor_copy_username"
+ android:background="@null"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="end"
android:layout_marginTop="10dp"
android:layout_marginEnd="15dp"
android:src="@drawable/ic_content_copy"
- android:contentDescription="@string/password_entry_editor_copy_stored_username" />
-
+ android:contentDescription="@string/password_entry_editor_copy_stored_username"
+ style="?android:attr/buttonStyleSmall" />
+
</LinearLayout>
-
+
<TextView
android:text="@string/password_entry_editor_password"
android:textColor="@color/google_blue_700"
@@ -106,12 +110,12 @@
android:layout_marginStart="15dp"
android:gravity="center_vertical"
android:textAppearance="?android:attr/textAppearanceMedium" />
-
+
<LinearLayout
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:orientation="horizontal">
-
+
<TextView
android:id="@+id/password_entry_editor_password"
android:textColor="@color/default_text_color"
@@ -120,34 +124,38 @@
android:layout_marginTop="10dp"
android:layout_marginStart="15dp"
android:textAppearance="?android:attr/textAppearanceMedium" />
-
+
<View
android:layout_width="0dp"
android:layout_height="0dp"
android:layout_weight="1" />
-
+
<ImageButton
- style="?android:attr/buttonStyleSmall"
+ android:id="@+id/password_entry_editor_view_password"
+ android:background="@null"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="end"
android:layout_marginTop="10dp"
android:layout_marginEnd="15dp"
android:src="@drawable/ic_visibility"
- android:contentDescription="@string/password_entry_editor_view_stored_password" />
-
+ android:contentDescription="@string/password_entry_editor_view_stored_password"
+ style="?android:attr/buttonStyleSmall" />
+
<ImageButton
- style="?android:attr/buttonStyleSmall"
+ android:id="@+id/password_entry_editor_copy_password"
+ android:background="@null"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="end"
android:layout_marginTop="10dp"
android:layout_marginEnd="15dp"
android:src="@drawable/ic_content_copy"
- android:contentDescription="@string/password_entry_editor_copy_stored_password" />
-
+ android:contentDescription="@string/password_entry_editor_copy_stored_password"
+ style="?android:attr/buttonStyleSmall" />
+
</LinearLayout>
</LinearLayout>
-</ScrollView>
+</ScrollView>

Powered by Google App Engine
This is Rietveld 408576698