Chromium Code Reviews Chromium Code Reviews
Issue 2900173002:
Copy and view saved passwords. (Closed)
| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2016 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2016 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android" | 6 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android" |
| 7 android:layout_width="match_parent" | 7 android:layout_width="match_parent" |
| 8 android:layout_height="match_parent" | 8 android:layout_height="match_parent" |
| 9 android:fillViewport="true" > | 9 android:fillViewport="true" > |
| 10 | 10 |
| 11 <LinearLayout | 11 <LinearLayout |
| 12 android:id="@+id/password_entry_editor_interactive" | 12 android:id="@+id/password_entry_editor_interactive" |
| 13 android:layout_width="match_parent" | 13 android:layout_width="match_parent" |
| 14 android:layout_height="wrap_content" | 14 android:layout_height="wrap_content" |
| 15 android:orientation="vertical" | 15 android:orientation="vertical" |
| 16 android:title="@string/password_entry_editor_title"> | 16 android:title="@string/password_entry_editor_title"> |
| 17 | 17 |
| 18 <TextView | 18 <TextView |
| 19 android:text="@string/password_entry_editor_site_title" | 19 android:text="@string/password_entry_editor_site_title" |
| 20 android:textColor="@color/google_blue_700" | 20 android:textColor="@color/google_blue_700" |
| 21 android:layout_width="wrap_content" | 21 android:layout_width="wrap_content" |
| 22 android:layout_height="wrap_content" | 22 android:layout_height="wrap_content" |
| 23 android:layout_marginTop="10dp" | 23 android:layout_marginTop="10dp" |
| 24 android:layout_marginStart="15dp" | 24 android:layout_marginStart="15dp" |
| 25 android:gravity="center_vertical" | 25 android:gravity="center_vertical" |
| 26 android:textAppearance="?android:attr/textAppearanceMedium" /> | 26 android:textAppearance="?android:attr/textAppearanceMedium" /> |
| 27 | 27 |
| 28 <LinearLayout | 28 <LinearLayout |
| 29 android:layout_width="wrap_content" | 29 android:layout_width="wrap_content" |
| 30 android:layout_height="wrap_content" | 30 android:layout_height="wrap_content" |
| 31 android:orientation="horizontal"> | 31 android:orientation="horizontal"> |
| 32 | 32 |
| 33 <TextView | 33 <TextView |
| 34 android:id="@+id/password_entry_editor_url" | 34 android:id="@+id/password_entry_editor_url" |
| 35 android:textColor="@color/default_text_color" | 35 android:textColor="@color/default_text_color" |
| 36 android:layout_width="fill_parent" | 36 android:layout_width="fill_parent" |
| 37 android:layout_height="wrap_content" | 37 android:layout_height="wrap_content" |
| 38 android:layout_marginTop="10dp" | 38 android:layout_marginTop="10dp" |
| 39 android:layout_marginStart="15dp" | 39 android:layout_marginStart="15dp" |
| 40 android:textAppearance="?android:attr/textAppearanceMedium" /> | 40 android:textAppearance="?android:attr/textAppearanceMedium" /> |
| 41 | 41 |
| 42 <View | 42 <View |
| 43 android:layout_width="0dp" | 43 android:layout_width="0dp" |
| 44 android:layout_height="0dp" | 44 android:layout_height="0dp" |
| 45 android:layout_weight="1" /> | 45 android:layout_weight="1" /> |
| 46 | 46 |
| 47 <ImageButton | 47 <ImageButton |
| 48 style="?android:attr/buttonStyleSmall" | 48 android:id="@+id/password_entry_editor_copy_site" |
| 49 android:background="@null" | |
| 49 android:layout_width="match_parent" | 50 android:layout_width="match_parent" |
| 50 android:layout_height="wrap_content" | 51 android:layout_height="wrap_content" |
| 51 android:layout_gravity="end" | 52 android:layout_gravity="end" |
| 52 android:layout_marginTop="10dp" | 53 android:layout_marginTop="10dp" |
| 53 android:layout_marginEnd="15dp" | 54 android:layout_marginEnd="15dp" |
| 54 android:src="@drawable/ic_content_copy" | 55 android:src="@drawable/ic_content_copy" |
| 55 android:contentDescription="@string/password_entry_editor_copy_s tored_site" /> | 56 android:contentDescription="@string/password_entry_editor_copy_s tored_site" |
| 56 | 57 style="?android:attr/buttonStyleSmall" /> |
| 58 | |
| 57 </LinearLayout> | 59 </LinearLayout> |
| 58 | 60 |
| 59 <TextView | 61 <TextView |
| 60 android:text="@string/password_entry_editor_username_title" | 62 android:text="@string/password_entry_editor_username_title" |
| 61 android:textColor="@color/google_blue_700" | 63 android:textColor="@color/google_blue_700" |
| 62 android:layout_width="wrap_content" | 64 android:layout_width="wrap_content" |
| 63 android:layout_height="wrap_content" | 65 android:layout_height="wrap_content" |
| 64 android:layout_marginTop="5dp" | 66 android:layout_marginTop="5dp" |
| 65 android:layout_marginStart="15dp" | 67 android:layout_marginStart="15dp" |
| 66 android:gravity="center_vertical" | 68 android:gravity="center_vertical" |
| 67 android:textAppearance="?android:attr/textAppearanceMedium" /> | 69 android:textAppearance="?android:attr/textAppearanceMedium" /> |
| 68 | 70 |
| 69 <LinearLayout | 71 <LinearLayout |
| 70 android:layout_width="wrap_content" | 72 android:layout_width="wrap_content" |
| 71 android:layout_height="wrap_content" | 73 android:layout_height="wrap_content" |
| 72 android:orientation="horizontal"> | 74 android:orientation="horizontal"> |
| 73 | 75 |
| 74 <TextView | 76 <TextView |
| 75 android:id="@+id/password_entry_editor_name" | 77 android:id="@+id/password_entry_editor_name" |
| 76 android:textColor="@color/default_text_color" | 78 android:textColor="@color/default_text_color" |
| 77 android:layout_width="fill_parent" | 79 android:layout_width="fill_parent" |
| 78 android:layout_height="wrap_content" | 80 android:layout_height="wrap_content" |
| 79 android:layout_marginTop="10dp" | 81 android:layout_marginTop="10dp" |
| 80 android:layout_marginStart="15dp" | 82 android:layout_marginStart="15dp" |
| 81 android:textAppearance="?android:attr/textAppearanceMedium" /> | 83 android:textAppearance="?android:attr/textAppearanceMedium" /> |
| 82 | 84 |
| 83 <View | 85 <View |
| 84 android:layout_width="0dp" | 86 android:layout_width="0dp" |
| 85 android:layout_height="0dp" | 87 android:layout_height="0dp" |
| 86 android:layout_weight="1" /> | 88 android:layout_weight="1" /> |
| 87 | 89 |
| 88 <ImageButton | 90 <ImageButton |
| 89 style="?android:attr/buttonStyleSmall" | 91 android:id="@+id/password_entry_editor_copy_username" |
| 92 android:background="@null" | |
| 90 android:layout_width="match_parent" | 93 android:layout_width="match_parent" |
| 91 android:layout_height="wrap_content" | 94 android:layout_height="wrap_content" |
| 92 android:layout_gravity="end" | 95 android:layout_gravity="end" |
| 93 android:layout_marginTop="10dp" | 96 android:layout_marginTop="10dp" |
| 94 android:layout_marginEnd="15dp" | 97 android:layout_marginEnd="15dp" |
| 95 android:src="@drawable/ic_content_copy" | 98 android:src="@drawable/ic_content_copy" |
| 96 android:contentDescription="@string/password_entry_editor_copy_s tored_username" /> | 99 android:contentDescription="@string/password_entry_editor_copy_s tored_username" |
| 97 | 100 style="?android:attr/buttonStyleSmall" /> |
| 101 | |
| 98 </LinearLayout> | 102 </LinearLayout> |
| 99 | 103 |
| 100 <TextView | 104 <TextView |
| 101 android:text="@string/password_entry_editor_password" | 105 android:text="@string/password_entry_editor_password" |
| 102 android:textColor="@color/google_blue_700" | 106 android:textColor="@color/google_blue_700" |
| 103 android:layout_width="wrap_content" | 107 android:layout_width="wrap_content" |
| 104 android:layout_height="wrap_content" | 108 android:layout_height="wrap_content" |
| 105 android:layout_marginTop="5dp" | 109 android:layout_marginTop="5dp" |
| 106 android:layout_marginStart="15dp" | 110 android:layout_marginStart="15dp" |
| 107 android:gravity="center_vertical" | 111 android:gravity="center_vertical" |
| 108 android:textAppearance="?android:attr/textAppearanceMedium" /> | 112 android:textAppearance="?android:attr/textAppearanceMedium" /> |
| 109 | 113 |
| 110 <LinearLayout | 114 <LinearLayout |
| 111 android:layout_width="wrap_content" | 115 android:layout_width="wrap_content" |
| 112 android:layout_height="wrap_content" | 116 android:layout_height="wrap_content" |
| 113 android:orientation="horizontal"> | 117 android:orientation="horizontal"> |
| 114 | 118 |
| 115 <TextView | 119 <TextView |
| 116 android:id="@+id/password_entry_editor_password" | 120 android:id="@+id/password_entry_editor_password" |
| 117 android:textColor="@color/default_text_color" | 121 android:textColor="@color/default_text_color" |
| 122 android:background="@android:color/transparent" | |
|
gone
2017/06/01 20:46:37
Is this necessary?
melandory
2017/06/09 15:09:27
Done.
| |
| 118 android:layout_width="fill_parent" | 123 android:layout_width="fill_parent" |
| 119 android:layout_height="wrap_content" | 124 android:layout_height="wrap_content" |
| 120 android:layout_marginTop="10dp" | 125 android:layout_marginTop="10dp" |
| 121 android:layout_marginStart="15dp" | 126 android:layout_marginStart="15dp" |
| 122 android:textAppearance="?android:attr/textAppearanceMedium" /> | 127 android:textAppearance="?android:attr/textAppearanceMedium" /> |
| 123 | 128 |
| 124 <View | 129 <View |
| 125 android:layout_width="0dp" | 130 android:layout_width="0dp" |
| 126 android:layout_height="0dp" | 131 android:layout_height="0dp" |
| 127 android:layout_weight="1" /> | 132 android:layout_weight="1" /> |
| 128 | 133 |
| 129 <ImageButton | 134 <ImageButton |
| 130 style="?android:attr/buttonStyleSmall" | 135 android:id="@+id/password_entry_editor_view_password" |
| 136 android:background="@null" | |
| 131 android:layout_width="match_parent" | 137 android:layout_width="match_parent" |
| 132 android:layout_height="wrap_content" | 138 android:layout_height="wrap_content" |
| 133 android:layout_gravity="end" | 139 android:layout_gravity="end" |
| 134 android:layout_marginTop="10dp" | 140 android:layout_marginTop="10dp" |
| 135 android:layout_marginEnd="15dp" | 141 android:layout_marginEnd="15dp" |
| 136 android:src="@drawable/ic_visibility" | 142 android:src="@drawable/ic_visibility" |
| 137 android:contentDescription="@string/password_entry_editor_view_s tored_password" /> | 143 android:contentDescription="@string/password_entry_editor_view_s tored_password" |
| 138 | 144 style="?android:attr/buttonStyleSmall" /> |
| 145 | |
| 139 <ImageButton | 146 <ImageButton |
| 140 style="?android:attr/buttonStyleSmall" | 147 android:id="@+id/password_entry_editor_copy_password" |
| 148 android:background="@null" | |
| 141 android:layout_width="match_parent" | 149 android:layout_width="match_parent" |
| 142 android:layout_height="wrap_content" | 150 android:layout_height="wrap_content" |
| 143 android:layout_gravity="end" | 151 android:layout_gravity="end" |
| 144 android:layout_marginTop="10dp" | 152 android:layout_marginTop="10dp" |
| 145 android:layout_marginEnd="15dp" | 153 android:layout_marginEnd="15dp" |
| 146 android:src="@drawable/ic_content_copy" | 154 android:src="@drawable/ic_content_copy" |
| 147 android:contentDescription="@string/password_entry_editor_copy_s tored_password" /> | 155 android:contentDescription="@string/password_entry_editor_copy_s tored_password" |
| 148 | 156 style="?android:attr/buttonStyleSmall" /> |
| 157 | |
| 149 </LinearLayout> | 158 </LinearLayout> |
| 150 | 159 |
| 151 </LinearLayout> | 160 </LinearLayout> |
| 152 | 161 |
| 153 </ScrollView> | 162 </ScrollView> |
| OLD | NEW |
