Move all remaining files to gcm_driver component

Move all remaining files to gcm_driver component

BUG=356716
TEST=existing tests
TBR=pavely@chromium.org,kalman@chromium.org,arv@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273140

[Nicolas Zea, 2014-05-24 00:06:23]

nice, LGTM!

[blundell, 2014-05-26 07:31:56]

LGTM

https://codereview.chromium.org/290013011/diff/1/components/components_tests.gyp
File components/components_tests.gyp (right):

https://codereview.chromium.org/290013011/diff/1/components/components_tests....
components/components_tests.gyp:367: ['include', '^dom_distiller/'],
Please add gcm_driver here.

https://codereview.chromium.org/290013011/diff/1/components/gcm_driver.gypi
File components/gcm_driver.gypi (right):

https://codereview.chromium.org/290013011/diff/1/components/gcm_driver.gypi#n...
components/gcm_driver.gypi:11: 'os_crypt',
It looks like there should be a google_apis dependency here?

https://codereview.chromium.org/290013011/diff/1/components/gcm_driver/fake_g...
File components/gcm_driver/fake_gcm_client_factory.h (right):

https://codereview.chromium.org/290013011/diff/1/components/gcm_driver/fake_g...
components/gcm_driver/fake_gcm_client_factory.h:10: #include
"components/gcm_driver/fake_gcm_client.h"
aside: What is this class needed for? It seems like any test that wants to build
a FakeGCMClient could just do so manually.

[fgorski, 2014-05-27 16:25:21]

lgtm

[jianli, 2014-05-27 17:27:54]

https://codereview.chromium.org/290013011/diff/1/components/components_tests.gyp
File components/components_tests.gyp (right):

https://codereview.chromium.org/290013011/diff/1/components/components_tests....
components/components_tests.gyp:367: ['include', '^dom_distiller/'],
On 2014/05/26 07:31:56, blundell wrote:
> Please add gcm_driver here.

Done.

https://codereview.chromium.org/290013011/diff/1/components/gcm_driver.gypi
File components/gcm_driver.gypi (right):

https://codereview.chromium.org/290013011/diff/1/components/gcm_driver.gypi#n...
components/gcm_driver.gypi:11: 'os_crypt',
On 2014/05/26 07:31:56, blundell wrote:
> It looks like there should be a google_apis dependency here?

I've already added the dependency to ../google_apis/gcm/gcm.gyp:gcm at line 14.

https://codereview.chromium.org/290013011/diff/1/components/gcm_driver/fake_g...
File components/gcm_driver/fake_gcm_client_factory.h (right):

https://codereview.chromium.org/290013011/diff/1/components/gcm_driver/fake_g...
components/gcm_driver/fake_gcm_client_factory.h:10: #include
"components/gcm_driver/fake_gcm_client.h"
On 2014/05/26 07:31:56, blundell wrote:
> aside: What is this class needed for? It seems like any test that wants to
build
> a FakeGCMClient could just do so manually.

We want to allow the production code and testing code to create the GCMClient
instance differently. Also GCMClient has to be created at certain point from IO
thread. So we cannot create it manually and pass it at the beginning. This is
the reason we introduce a factory.

[jianli, 2014-05-27 19:51:20]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-05-27 19:51:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jianli@chromium.org/290013011/40001

[commit-bot: I haz the power, 2014-05-27 21:11:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-28 03:18:58]

Change committed as 273140