Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Issue 290013005: DevTools: Fix use-after-free in DevToolsUIBindings::Unsubscribe (Closed)

Created:
6 years, 7 months ago by alph
Modified:
6 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

DevTools: Fix use-after-free in DevToolsUIBindings::Unsubscribe R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
alph
6 years, 7 months ago (2014-05-22 13:46:03 UTC) #1
pfeldman
lgtm
6 years, 7 months ago (2014-05-22 14:48:34 UTC) #2
alph
The CQ bit was checked by alph@chromium.org
6 years, 7 months ago (2014-05-22 14:49:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/290013005/1
6 years, 7 months ago (2014-05-22 14:51:05 UTC) #4
alph
The CQ bit was unchecked by alph@chromium.org
6 years, 7 months ago (2014-05-22 17:22:40 UTC) #5
alph
The CQ bit was checked by alph@chromium.org
6 years, 7 months ago (2014-05-22 17:22:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/290013005/1
6 years, 7 months ago (2014-05-22 17:28:07 UTC) #7
alph
6 years, 7 months ago (2014-05-22 18:23:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r272243 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698