Issue 2900113002: Implement subtyping rules for FutureOr in kernel.

Issue 2900113002: Implement subtyping rules for FutureOr in kernel. (Closed)

Created:
3 years, 7 months ago by Paul Berry

Modified:
3 years, 7 months ago

Reviewers:
scheglov, ahe, Kevin Millikin (Google)

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, asgerf

Target Ref:
refs/heads/master

Visibility:
Public.

Implement subtyping rules for FutureOr in kernel. These rules are only enabled when in strong mode, so existing Dart 1.0 functionality should be unaffected. R=kmillikin@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e642722f42b523953227187f7cd7bfacbb31f47b

Total comments: 1

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -15 lines)			Patch
M	pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	pkg/front_end/test/fasta/type_inference/type_constraint_gatherer_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/front_end/test/fasta/type_inference/type_schema_environment_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/kernel/lib/type_environment.dart	View	4 chunks	+38 lines, -0 lines	1 comment	Download
M	pkg/kernel/test/type_subtype_test.dart	View	4 chunks	+47 lines, -11 lines	0 comments	Download

Total messages: 6 (2 generated)

Paul Berry

Konstantin to review front_end changes Kevin or Peter to review kernel changes. Note that the ...

3 years, 7 months ago (2017-05-23 17:36:39 UTC) #2

Paul Berry

3 years, 7 months ago (2017-05-24 13:14:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e642722f42b523953227187f7cd7bfacbb31f47b (presubmit successful).