media/audio/audio_output_controller.h - Issue 2900043002: Added initial set of logging for AudioOutputController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_output_controller.h

Issue 2900043002: Added initial set of logging for AudioOutputController. (Closed)

Patch Set: Turned DoLog static, so we can log things even when delegate_ has disappeared. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/audio_output_controller.h

diff --git a/media/audio/audio_output_controller.h b/media/audio/audio_output_controller.h

index 2c8bc52bba48dfed5f453c8102a8ca1c3b08550f..8e8bbac115d7fde78624f993f331e96ca8d02414 100644

--- a/media/audio/audio_output_controller.h

+++ b/media/audio/audio_output_controller.h

@@ -76,6 +76,8 @@ class MEDIA_EXPORT AudioOutputController

virtual void OnControllerPaused() = 0;

virtual void OnControllerError() = 0;

liberato (no reviews please) 2017/05/30 16:53:35 please delete the extra blank line, here and elsew

+ virtual void OnLog(const std::string& message) = 0;

protected:

virtual ~EventHandler() {}

};