Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Unified Diff: content/browser/renderer_host/media/audio_output_delegate_impl.h

Issue 2900043002: Added initial set of logging for AudioOutputController. (Closed)
Patch Set: Turned DoLog static, so we can log things even when delegate_ has disappeared. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_output_delegate_impl.h
diff --git a/content/browser/renderer_host/media/audio_output_delegate_impl.h b/content/browser/renderer_host/media/audio_output_delegate_impl.h
index 9a2c89aef7d45a985db4b54af8c8ec1340696fca..d4b9435f2068150e8859c0956bf404a8b4dd587d 100644
--- a/content/browser/renderer_host/media/audio_output_delegate_impl.h
+++ b/content/browser/renderer_host/media/audio_output_delegate_impl.h
@@ -71,6 +71,7 @@ class CONTENT_EXPORT AudioOutputDelegateImpl
void SendCreatedNotification();
void OnError();
+ static void DoLog(int stream_id, const std::string& msg);
liberato (no reviews please) 2017/05/30 16:53:34 please add a comment about why this needs to be st
ossu-chromium 2017/05/31 11:16:27 I've looked at this again and I think it would be
void UpdatePlayingState(bool playing);
media::AudioOutputController* GetControllerForTesting() const;

Powered by Google App Engine
This is Rietveld 408576698