Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 290003006: Land recent SPDY changes (through 67282679) (Closed)

Created:
6 years, 7 months ago by Johnny
Modified:
6 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Land recent SPDY changes (through 67282679) Lazily alloc/init the HPACK encoder/decoder. This lands server change 66441587 by hkhalil. https://codereview.chromium.org/292543002/ Cleanup: Remove redundant SpdyFramerTest string conversions. This lands server change 66517765 by hwright. https://codereview.chromium.org/283343003/ Adds reporting of total header block bytes to SpdyHeadersBlockParser. This lands server change 66798542 by birenroy. https://codereview.chromium.org/288313006/ Moves HpackEntry index computation into the container class HpackHeaderTable. No functional change. This lands server change 66892433 by birenroy. https://codereview.chromium.org/289843007/ Add handling + parsing for HTTP/2 ALTSVC frame. Also change frame type number and add an extra version check for BLOCKED frame. This lands server change 66925490 by mlavan. https://codereview.chromium.org/288373004/ Update SPDY4 flags for '12 specification draft Renumbers existing PAD_LOW, PAD_HIGH, and PRIORITY flags. Adds remaining PAD_LOW, PAD_HIGH, END_SEGMENT, and COMPRESSED flags. No behavior changes. This lands server change 67012065 by jgraettinger. https://codereview.chromium.org/284283006/ Accept and ignore PRIORITY frames in SPDY4+. Proper parsing/handling coming in a later CL. This lands server change 67153714 by hkhalil. https://codereview.chromium.org/286313002/ Accept SETTINGS_COMPRESS_DATA frames for HTTP2. Currently do nothing with them. This lands server change 67271146 by mlavan. https://codereview.chromium.org/286143011/ HTTP/2 framer support for reading headers with padding, and for segments. Header padding may be read, but serialization support is TODO. Segment boundaries are likewise accepted, but discarded. This lands server change 67282679 by jgraettinger. https://codereview.chromium.org/290203003/ BUG=345769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271309

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase on nullptr => NULL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1196 lines, -332 lines) Patch
M net/spdy/hpack_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_decoder_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_encoder.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M net/spdy/hpack_encoder_test.cc View 12 chunks +21 lines, -17 lines 0 comments Download
M net/spdy/hpack_entry.h View 3 chunks +19 lines, -30 lines 0 comments Download
M net/spdy/hpack_entry.cc View 1 chunk +7 lines, -36 lines 0 comments Download
M net/spdy/hpack_entry_test.cc View 5 chunks +26 lines, -67 lines 0 comments Download
M net/spdy/hpack_header_table.h View 5 chunks +22 lines, -8 lines 0 comments Download
M net/spdy/hpack_header_table.cc View 8 chunks +39 lines, -18 lines 0 comments Download
M net/spdy/hpack_header_table_test.cc View 10 chunks +84 lines, -9 lines 0 comments Download
M net/spdy/mock_spdy_framer_visitor.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 10 chunks +56 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 2 35 chunks +299 lines, -52 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 49 chunks +488 lines, -51 lines 0 comments Download
M net/spdy/spdy_headers_block_parser.h View 2 chunks +6 lines, -2 lines 0 comments Download
M net/spdy/spdy_headers_block_parser.cc View 5 chunks +6 lines, -1 line 0 comments Download
M net/spdy/spdy_headers_block_parser_test.cc View 7 chunks +17 lines, -11 lines 0 comments Download
M net/spdy/spdy_protocol.h View 1 5 chunks +63 lines, -16 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 1 8 chunks +24 lines, -5 lines 0 comments Download
M net/spdy/spdy_protocol_test.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Johnny
6 years, 7 months ago (2014-05-16 22:29:29 UTC) #1
Ryan Hamilton
lgtm
6 years, 7 months ago (2014-05-17 00:18:07 UTC) #2
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 7 months ago (2014-05-18 15:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/290003006/40001
6 years, 7 months ago (2014-05-18 15:50:00 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-18 19:02:06 UTC) #5
Message was sent while issue was closed.
Change committed as 271309

Powered by Google App Engine
This is Rietveld 408576698