Create KernelSsaBuilder from KernelSsaBuilderTask

Create KernelSsaBuilder from KernelSsaBuilderTask

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/ccc6c484b378eda77c3d70e0dbdccec5a0d69296

[Johnni Winther, 2017-05-23 10:45:19]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-23 21:23:31]

lgtm

https://codereview.chromium.org/2899983003/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2899983003/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:51: //
TODO(johnniwinther,efortuna): Avoid the need for AST nodes in the locals
can we really avoid it?

https://codereview.chromium.org/2899983003/diff/1/pkg/compiler/lib/src/ssa/ra...
File pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart (right):

https://codereview.chromium.org/2899983003/diff/1/pkg/compiler/lib/src/ssa/ra...
pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart:37: //work.resolvedAst,
delete

[Johnni Winther, 2017-05-24 08:07:09]

https://codereview.chromium.org/2899983003/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2899983003/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:51: //
TODO(johnniwinther,efortuna): Avoid the need for AST nodes in the locals
On 2017/05/23 21:23:31, Siggi Cherem (dart-lang) wrote:
> can we really avoid it?

They are just used as keys to fetch the corresponding ClosureScope. Any key (AST
node, ir.Node, or other) should do.

https://codereview.chromium.org/2899983003/diff/1/pkg/compiler/lib/src/ssa/ra...
File pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart (right):

https://codereview.chromium.org/2899983003/diff/1/pkg/compiler/lib/src/ssa/ra...
pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart:37: //work.resolvedAst,
On 2017/05/23 21:23:31, Siggi Cherem (dart-lang) wrote:
> delete

Done.

[Johnni Winther, 2017-05-24 08:12:27]

Description was changed from

==========
Create KernelSsaBuilder from KernelSsaBuilderTask
==========

to

==========
Create KernelSsaBuilder from KernelSsaBuilderTask

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ccc6c484b378eda77c3d70e0dbdccec5a0d69296
==========

[Johnni Winther, 2017-05-24 08:12:29]

Committed patchset #2 (id:20001) manually as
ccc6c484b378eda77c3d70e0dbdccec5a0d69296 (presubmit successful).