Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Issue 2899973003: [wip]devtools
Patch Set: cleanup Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
index beaefd455791c983a89cefcdf300ecf5f9fdc757..872e9e06307895a917fcea8a49818b90e56ce00e 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
@@ -292,7 +292,6 @@ SDK.NetworkDispatcher = class {
/**
* @override
* @param {!Protocol.Network.RequestId} requestId
- * @param {!Protocol.Page.FrameId} frameId
* @param {!Protocol.Network.LoaderId} loaderId
* @param {string} documentURL
* @param {!Protocol.Network.Request} request
@@ -301,28 +300,21 @@ SDK.NetworkDispatcher = class {
* @param {!Protocol.Network.Initiator} initiator
* @param {!Protocol.Network.Response=} redirectResponse
* @param {!Protocol.Page.ResourceType=} resourceType
+ * @param {!Protocol.Page.FrameId=} frameId
*/
requestWillBeSent(
- requestId,
- frameId,
- loaderId,
- documentURL,
- request,
- time,
- wallTime,
- initiator,
- redirectResponse,
- resourceType) {
+ requestId, loaderId, documentURL, request, time, wallTime, initiator, redirectResponse, resourceType, frameId) {
var networkRequest = this._inflightRequestsById[requestId];
if (networkRequest) {
// FIXME: move this check to the backend.
if (!redirectResponse)
return;
- this.responseReceived(requestId, frameId, loaderId, time, Protocol.Page.ResourceType.Other, redirectResponse);
+ this.responseReceived(requestId, loaderId, time, Protocol.Page.ResourceType.Other, redirectResponse, frameId);
networkRequest = this._appendRedirect(requestId, time, request.url);
this._manager.dispatchEventToListeners(SDK.NetworkManager.Events.RequestRedirected, networkRequest);
} else {
- networkRequest = this._createNetworkRequest(requestId, frameId, loaderId, request.url, documentURL, initiator);
+ networkRequest =
+ this._createNetworkRequest(requestId, frameId ? frameId : '', loaderId, request.url, documentURL, initiator);
}
networkRequest.hasNetworkData = true;
this._updateNetworkRequestWithRequest(networkRequest, request);
@@ -348,19 +340,19 @@ SDK.NetworkDispatcher = class {
/**
* @override
* @param {!Protocol.Network.RequestId} requestId
- * @param {!Protocol.Page.FrameId} frameId
* @param {!Protocol.Network.LoaderId} loaderId
* @param {!Protocol.Network.Timestamp} time
* @param {!Protocol.Page.ResourceType} resourceType
* @param {!Protocol.Network.Response} response
+ * @param {!Protocol.Page.FrameId=} frameId
*/
- responseReceived(requestId, frameId, loaderId, time, resourceType, response) {
+ responseReceived(requestId, loaderId, time, resourceType, response, frameId) {
var networkRequest = this._inflightRequestsById[requestId];
if (!networkRequest) {
// We missed the requestWillBeSent.
var eventData = {};
eventData.url = response.url;
- eventData.frameId = frameId;
+ eventData.frameId = frameId ? frameId : '';
eventData.loaderId = loaderId;
eventData.resourceType = resourceType;
eventData.mimeType = response.mimeType;

Powered by Google App Engine
This is Rietveld 408576698