Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(77)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: content/test/data/android/permission_navigation.html
Issue
2899973002
:
Hide modal permission prompts on Android upon tab navigation/destruction (Closed)
Patch Set: address comments
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/android/BUILD.gn
chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java
chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogDelegate.java
chrome/android/java_sources.gni
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionNavigationTest.java
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestCaseBase.java
chrome/browser/permissions/permission_dialog_delegate.h
chrome/browser/permissions/permission_dialog_delegate.cc
content/test/data/android/permission_navigation.html
View unified diff
|
Download patch
« chrome/browser/permissions/permission_dialog_delegate.cc
('K') |
« chrome/browser/permissions/permission_dialog_delegate.cc
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
3
<script>
4
function navigate() {
5
window.location = "about:blank";
6
}
7
8
function requestGeolocationPermission() {
9
navigator.geolocation.getCurrentPosition(function() { });
10
}
11
12
function requestNotificationPermission() {
13
Notification.requestPermission();
14
}
15
</script>
OLD
NEW
« chrome/browser/permissions/permission_dialog_delegate.cc
('K') |
« chrome/browser/permissions/permission_dialog_delegate.cc
('k') |
no next file »
|
no next file with comments »
Issue 2899973002: Hide modal permission prompts on Android upon tab navigation/destruction (Closed)
Created 3 years, 7 months ago by Timothy Loh
Modified 3 years, 6 months ago
Reviewers: dominickn, raymes, Bernhard Bauer
Base URL:
Comments: 33
This is Rietveld
408576698
Chromium Code Reviews
Issue 2899973002:
Hide modal permission prompts on Android upon tab navigation/destruction (Closed)
