Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 2899843002: Convert quick assist support to use AnalysisDriver (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -169 lines) Patch
M pkg/analysis_server/lib/plugin/edit/assist/assist_core.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/assist/assist_dart.dart View 4 chunks +14 lines, -30 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/fix/fix_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 6 chunks +51 lines, -65 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist.dart View 2 chunks +3 lines, -40 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 7 chunks +26 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 4 chunks +5 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Also a bit of missed clean-up from the previous CL.
3 years, 7 months ago (2017-05-22 18:58:33 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-22 19:01:16 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-22 20:46:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0929b7736ea831d4b55a901b74de944818ce6a04 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698