Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 289983004: Remove unnecessary NULL check in DOMWindow::top() (Closed)

Created:
6 years, 7 months ago by davve
Modified:
6 years, 7 months ago
CC:
blink-reviews, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unnecessary NULL check in DOMWindow::top() https://chromium.googlesource.com/chromium/blink/+/c07c40ae84d58b96cb44ad6c03d89a1b5438470b The use of |page| in DOMWindow::top() was replaced by going to the frame tree, but the NULL check for |page| was not removed. Remove it. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/core/frame/DOMWindow.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davve
Stumbled upon these seemingly unnecessary lines while scanning through the code. PTAL at your leisure.
6 years, 7 months ago (2014-05-16 07:53:30 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-16 07:54:37 UTC) #2
davve
The CQ bit was checked by davve@opera.com
6 years, 7 months ago (2014-05-16 09:22:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/289983004/1
6 years, 7 months ago (2014-05-16 09:22:26 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 09:36:29 UTC) #5
Message was sent while issue was closed. 
Change committed as 174148

Powered by Google App Engine
This is Rietveld 408576698