Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: tools/ninja.py

Issue 2899803002: Adds deprecation messages for MIPS cross-builds (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/ninja.py
diff --git a/tools/ninja.py b/tools/ninja.py
index 7a2db651a7fb639d052b19ab452301a4021982fa..d7b6ee8b80d35d722e498709cde9ab27b2c00564 100755
--- a/tools/ninja.py
+++ b/tools/ninja.py
@@ -62,7 +62,7 @@ def ProcessOsOption(os_name):
def ProcessOptions(options, args):
if options.arch == 'all':
- options.arch = 'ia32,x64,simarm,simarm64,simmips,simdbc64'
+ options.arch = 'ia32,x64,simarm,simarm64,simdbc64'
if options.mode == 'all':
options.mode = 'debug,release,product'
if options.os == 'all':
@@ -225,6 +225,13 @@ def EnsureGomaStarted(out_dir):
# Returns a tuple (build_config, command to run, whether goma is used)
def BuildOneConfig(options, targets, target_os, mode, arch):
+ if arch.startswith('mips'):
+ bold = '\033[1m'
+ reset = '\033[0m'
+ print(bold + "Warning: MIPS architectures are unlikely to be supported in "
+ "upcoming releases. Please consider using another architecture "
+ "and/or file an issue explaining your specific use of and need for "
+ "MIPS support." + reset)
build_config = utils.GetBuildConf(mode, arch, target_os)
out_dir = utils.GetBuildRoot(HOST_OS, mode, arch, target_os)
using_goma = False
« no previous file with comments | « tools/gn.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698