Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 2899753002: Adjusted wording for "return anything from void =>" to include setters (Closed)

Created:
3 years, 7 months ago by eernst
Modified:
3 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, kevmoo
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjusted wording for "return anything from void =>" to include setters Addresses issue https://github.com/dart-lang/sdk/issues/29683. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/ecd86d9bfcc0840e4a78831090c767cb75374890

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M CHANGELOG.md View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
Adresses a missing case in #29646, as described in #29683.
3 years, 7 months ago (2017-05-22 13:55:37 UTC) #2
floitsch
LGTM.
3 years, 7 months ago (2017-05-22 13:56:48 UTC) #3
eernst
3 years, 7 months ago (2017-05-22 13:58:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ecd86d9bfcc0840e4a78831090c767cb75374890 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698