Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: extensions/utility/unpacker.cc

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)
Patch Set: Addressed nit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/message_bundle_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/utility/unpacker.cc
diff --git a/extensions/utility/unpacker.cc b/extensions/utility/unpacker.cc
index e946013292b07c6e10006a583600724add13beab..81b8d5a2af349b8c2927e1a50b6b02607fc5bbfd 100644
--- a/extensions/utility/unpacker.cc
+++ b/extensions/utility/unpacker.cc
@@ -318,7 +318,7 @@ bool Unpacker::ReadMessageCatalog(const base::FilePath& message_path) {
NOTREACHED();
return false;
}
- parsed_catalogs_->Set(dir_name, root.release());
+ parsed_catalogs_->Set(dir_name, std::move(root));
return true;
}
« no previous file with comments | « extensions/common/message_bundle_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698