Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: extensions/common/manifest_handlers/oauth2_manifest_unittest.cc

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)
Patch Set: Addressed nit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/file_util_unittest.cc ('k') | extensions/common/message_bundle_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_handlers/oauth2_manifest_unittest.cc
diff --git a/extensions/common/manifest_handlers/oauth2_manifest_unittest.cc b/extensions/common/manifest_handlers/oauth2_manifest_unittest.cc
index 34acffdd279bc11099aa1593ac819c4ec0a8b8e6..9172434e1fb95082b7eeae4dda9a20548195865a 100644
--- a/extensions/common/manifest_handlers/oauth2_manifest_unittest.cc
+++ b/extensions/common/manifest_handlers/oauth2_manifest_unittest.cc
@@ -4,7 +4,9 @@
#include <utility>
+#include "base/memory/ptr_util.h"
#include "base/test/values_test_util.h"
+#include "base/values.h"
#include "extensions/common/manifest_constants.h"
#include "extensions/common/manifest_handlers/oauth2_manifest_handler.h"
#include "extensions/common/manifest_test.h"
@@ -93,10 +95,10 @@ TEST_F(OAuth2ManifestTest, OAuth2SectionParsing) {
base_manifest.SetString(keys::kVersion, "0.1");
base_manifest.SetInteger(keys::kManifestVersion, 2);
base_manifest.SetString(keys::kOAuth2ClientId, "client1");
- base::ListValue* scopes = new base::ListValue();
+ auto scopes = base::MakeUnique<base::ListValue>();
scopes->AppendString("scope1");
scopes->AppendString("scope2");
- base_manifest.Set(keys::kOAuth2Scopes, scopes);
+ base_manifest.Set(keys::kOAuth2Scopes, std::move(scopes));
// OAuth2 section should be parsed for an extension.
{
« no previous file with comments | « extensions/common/file_util_unittest.cc ('k') | extensions/common/message_bundle_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698