Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: extensions/common/extension_set_unittest.cc

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)
Patch Set: Addressed nit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_l10n_util_unittest.cc ('k') | extensions/common/file_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/extension_set_unittest.cc
diff --git a/extensions/common/extension_set_unittest.cc b/extensions/common/extension_set_unittest.cc
index 83b598b4f05c94f3889e8ae3d3c0719e461827f0..9eeb8a68a7f9883312a905c6af5604c4a79b1a12 100644
--- a/extensions/common/extension_set_unittest.cc
+++ b/extensions/common/extension_set_unittest.cc
@@ -5,9 +5,11 @@
#include "extensions/common/extension_set.h"
#include <memory>
+#include <utility>
#include "base/files/file_path.h"
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/values.h"
#include "build/build_config.h"
@@ -36,9 +38,9 @@ scoped_refptr<Extension> CreateTestExtension(const std::string& name,
manifest.SetString("app.launch.web_url", launch_url);
if (!extent.empty()) {
- base::ListValue* urls = new base::ListValue();
- manifest.Set("app.urls", urls);
+ auto urls = base::MakeUnique<base::ListValue>();
urls->AppendString(extent);
+ manifest.Set("app.urls", std::move(urls));
}
std::string error;
« no previous file with comments | « extensions/common/extension_l10n_util_unittest.cc ('k') | extensions/common/file_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698