extensions/browser/guest_view/web_view/web_view_permission_helper.cc - Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_permission_helper.cc

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)

Patch Set: Addressed nit Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_find_helper.cc ('k') | extensions/browser/value_store/value_store_change.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_permission_helper.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

index dd76f458de35b76f0fe00e7b4abc3e254729e90e..c97c823cc69bf75e8fde0a216c80b6eaa9b059a5 100644

--- a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

+++ b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

@@ -11,6 +11,7 @@

#include "base/metrics/user_metrics.h"

#include "base/single_thread_task_runner.h"

#include "base/threading/thread_task_runner_handle.h"

+#include "base/values.h"

#include "components/guest_view/browser/guest_view_event.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/render_view_host.h"

@@ -330,7 +331,7 @@ int WebViewPermissionHelper::RequestPermission(

pending_permission_requests_[request_id] =

PermissionResponseInfo(callback, permission_type, allowed_by_default);

std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());

- args->Set(webview::kRequestInfo, request_info.DeepCopy());

+ args->Set(webview::kRequestInfo, base::MakeUnique<base::Value>(request_info));

args->SetInteger(webview::kRequestId, request_id);

switch (permission_type) {

case WEB_VIEW_PERMISSION_TYPE_NEW_WINDOW: {