extensions/browser/api/web_request/web_request_api_helpers.h - Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_api_helpers.h

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)

Patch Set: Addressed nit Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/web_request/web_request_api_helpers.h

diff --git a/extensions/browser/api/web_request/web_request_api_helpers.h b/extensions/browser/api/web_request/web_request_api_helpers.h

index d6da9813975969eb66c63557f4092c81e5f8d0a0..5542c88b1d9c88365da50cac2f4e2489733999cc 100644

--- a/extensions/browser/api/web_request/web_request_api_helpers.h

+++ b/extensions/browser/api/web_request/web_request_api_helpers.h

@@ -203,9 +203,8 @@ bool InDecreasingExtensionInstallationTimeOrder(

const linked_ptr<EventResponseDelta>& a,

const linked_ptr<EventResponseDelta>& b);

-// Converts a string to a list of integers, each in 0..255. Ownership

-// of the created list is passed to the caller.

-base::ListValue* StringToCharList(const std::string& s);

+// Converts a string to a list of integers, each in 0..255.

+std::unique_ptr<base::ListValue> StringToCharList(const std::string& s);

// Converts a list of integer values between 0 and 255 into a string |*out|.

// Returns true if the conversion was successful.