extensions/utility/unpacker.cc - Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/utility/unpacker.cc

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)

Patch Set: Addressed comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/utility/unpacker.cc

diff --git a/extensions/utility/unpacker.cc b/extensions/utility/unpacker.cc

index e946013292b07c6e10006a583600724add13beab..81b8d5a2af349b8c2927e1a50b6b02607fc5bbfd 100644

--- a/extensions/utility/unpacker.cc

+++ b/extensions/utility/unpacker.cc

@@ -318,7 +318,7 @@ bool Unpacker::ReadMessageCatalog(const base::FilePath& message_path) {

NOTREACHED();

return false;

}

- parsed_catalogs_->Set(dir_name, root.release());

+ parsed_catalogs_->Set(dir_name, std::move(root));

return true;

}