extensions/browser/guest_view/web_view/web_view_find_helper.cc - Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_find_helper.cc

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)

Patch Set: Addressed comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/web_view_find_helper.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_find_helper.cc b/extensions/browser/guest_view/web_view/web_view_find_helper.cc

index dc4c5828151960d384fca0d520f5406816ec9fcf..7c0aff0716cac161f45a500d797a8790c609eb0e 100644

--- a/extensions/browser/guest_view/web_view/web_view_find_helper.cc

+++ b/extensions/browser/guest_view/web_view/web_view_find_helper.cc

@@ -221,7 +221,8 @@ void WebViewFindHelper::FindResults::PrepareResults(

rect.SetInteger(webview::kFindRectTop, selection_rect_.y());

rect.SetInteger(webview::kFindRectWidth, selection_rect_.width());

rect.SetInteger(webview::kFindRectHeight, selection_rect_.height());

- results->Set(webview::kFindSelectionRect, rect.DeepCopy());

+ results->Set(webview::kFindSelectionRect,

+ base::MakeUnique<base::Value>(std::move(rect)));

}

WebViewFindHelper::FindUpdateEvent::FindUpdateEvent(