extensions/browser/api/app_runtime/app_runtime_api.cc - Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/app_runtime/app_runtime_api.cc

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/app_runtime/app_runtime_api.cc

diff --git a/extensions/browser/api/app_runtime/app_runtime_api.cc b/extensions/browser/api/app_runtime/app_runtime_api.cc

index b1093686210de1bdd487efd5403b9f44a81ea4d4..aeb5775b87f329e87f25afc6fe086dc9ca17f5cf 100644

--- a/extensions/browser/api/app_runtime/app_runtime_api.cc

+++ b/extensions/browser/api/app_runtime/app_runtime_api.cc

@@ -191,7 +191,7 @@ void AppRuntimeEventRouter::DispatchOnLaunchedEventWithFileEntries(

launch_item->SetBoolean("isDirectory", entries[i].is_directory);

items->Append(std::move(launch_item));

}

- launch_data->Set("items", items.release());

+ launch_data->Set("items", std::move(items));

DispatchOnLaunchedEventImpl(extension->id(), source_enum,

std::move(launch_data), context);

}